CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.31k stars 4.13k forks source link

Woods Soup contains meat but can be crafted without meat #23707

Closed DeltaR9A2 closed 5 years ago

DeltaR9A2 commented 6 years ago

Game version: Build 7388 Operating system: Windows 10 Tiles or curses: Tiles Mods active: [ "dda", "StatsThroughSkills", "filthy_morale", "no_npc_food", "novitamins", "more_classes_scenarios", "bio_mod", "realguns", "More_Survival_Tools", "national_guard_camp", "more_buildings", "more_locations", "Experimental-Z-Level", "Urban_Development", "blazemod", "deoxymod", "Tanks" ]

Expected behavior

My character with the Meat Intolerance trait could craft Woods Soup using broth, bird eggs, and wild vegetables and then eat it happily.

Actual behavior

The crafted soup contains meat and triggers the Meat Intolerance trait even though no meat was used during crafting.

Steps to reproduce the behavior

Have the Meat Intolerance trait, craft some Woods Soup using broth, eggs, and veggies. Eat the resulting soup and suffer.

Comments

Ideally a crafted item would "remember" its actual ingredients for situations like this but if I understand the way crafting works that isn't possible. Since woods soup is defined as being made of "Flesh" and "Vegetable Matter" but not "Egg" the recipe should probably be changed to remove egg options so that the soup must always be crafted from the materials it will be composed of. This way there is no surprise for characters with dietary restrictions.

Bonus Thought

I'm now imagining my character cooks up her Woods Soup using bird eggs and is extremely confused when she discovers fully formed chicken bones at the bottom of the pot.

FulcrumA commented 6 years ago

Yeah, remembering the ingredients used and adjusting stats/qualities of the item in reference to them (perhaps even leading to more generalized recipes, where name and some of the description of the final product depends on elements used) was mentioned quite a few times in the past. It'd be awesome but it'd really require a whole revamp of items and their crafting, not to mention balancing afterwards.

KorGgenT commented 5 years ago

this should be fixed due to #27689