CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.69k stars 4.2k forks source link

plant_stalk can be cooked without heat/fire #69057

Closed jackledead closed 11 months ago

jackledead commented 1 year ago

Describe the bug

I picked some wild shrub, got a plant stalk (which i believe recently was replaced from the burdock stalk) and I could cook it without having any tools or heat/flame.

If you look at the code I believe it's from some copy_from shenanigans.

{ "type": "recipe", "activity_level": "LIGHT_EXERCISE", "result": "cooked_burdock_stalk", "copy-from": "cooked_cattail_stalk", "components": [ [ [ "plant_stalk", 1 ] ] ] },

Attach save file

Mizpah_copy-trimmed.tar.gz

Steps to reproduce

debug spawn plant stalk. get recipe. get skills required. press & and make the cooked plant stalk with no fire.

Expected behavior

I expect to use heat/flame to cook the item like all the other veggie recipes.

Screenshots

plant stalk no fire

Versions and configuration

Additional context

No response

Karol1223 commented 1 year ago

It is indeed a problem with copy-from. It's been reported on Discord a bunch of times but I believe this is the first GitHub report. It could be trivially fixed in JSON but from what I heard the perfect solution would be to correct C++ copy-from behavior to fix the issue at the core.

GuardianDll commented 1 year ago

60257, both qualities and tools are not inherited

github-actions[bot] commented 12 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.