CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.69k stars 4.2k forks source link

Prevent split-second screen flashing from certain menu interactions (eating food), or add a photsensitive epilepsy warning. #69987

Open Zarhon opened 12 months ago

Zarhon commented 12 months ago

Is your feature request related to a problem? Please describe.

Certain menu actions that are commonly used can cause a sort of 'screen flash' effect. This is most noticable when you use the 'eating' menu - eating an item with any sort of 'eating time' causes the menu to close for a split-second and then reopen, which repeats for every single item you eat. Doing this in quick succession with certain food items thus produces a noticable 'screen flash' effect due to menus repeatedly opening and closing.

This, on its own, this is a fairly annoying eyestraing when you batch eat a number of items.

But the bigger issue is that it could be outright dangerous for anyone with photosensitive epilepsy. Such flashing is not present or rare in the game and could catch players 'by surprise'.

An example of this 'flashing' can be seen in the gif below (note: this is done during winter and I'm not capturing the whole screen, the slight pause is cause I was menu-ing). GIF

Solution you would like.

Modify the mechanics of eating so that the momentary 'screen flash' does not occur - keep the 'eating' window open and do the time-relevant stuff in the background.

Describe alternatives you have considered.

Add a photosensitive epilepsy warning to the game somewhere - either in its description (before downloading the game, in launchers, etc) or elsewhere noticeable. Something like "In rare cases, with certain tilesets or menu action, momentary screen flashing may occur."

Additional context

This effect also happens with various drugs - try eating 4 multivitamins or aspirins in quick succession and it will also happen (ignore the gif artifacts, gifcam couldn't capture it accurately). GIF

andrei8l commented 12 months ago

Similar to #62400 if anyone wants to tackle it. Probably easier too since inv_ui is not as ugly as the AIM.

Terrorforge commented 11 months ago

It's also just super annoying from a UX perspective, because the game accepts non-eating menu inputs during the "flash". Most notably, if you hold down 0 to eat a stack of something on a nearby tile, you end up opening the help menu.

github-actions[bot] commented 10 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

Zireael07 commented 10 months ago

This is an accessibility issue, as such it should be exempt from stalebot

github-actions[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

Zireael07 commented 8 months ago

Accessibility issues were supposed to be exempt from stalebot!

andrei8l commented 1 month ago

/confirm to reopen