CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.67k stars 4.18k forks source link

Mutations give "buff" stats instead of "base" stats #72698

Closed anoobindisguise closed 5 months ago

anoobindisguise commented 7 months ago

Describe the bug

Currently when you mutate a stat-boosting mutation such as Strong, it gives you the stats in the form of a stat buff (like bionics) instead of a base stat. This is important, because for stats base vs buff has many important distinctions. For strength for example, this influences your disease resistance, HP, and BMI-from-strength (muscle bodymass).

Attach save file

n/a

Steps to reproduce

  1. Make a character.
  2. Mutate Strong.
  3. Observe your strength stat is 9 (8) instead of 9 (9).
  4. Observe your HP and bodymass also didn't increase.

Expected behavior

Mutations should raise the base stat. EDIT: This is how it used to work before a recent enchantmentfication of the mutations.

Screenshots

image

Versions and configuration

Additional context

No response

kevingranade commented 7 months ago

I'm not at all sure mutations should increase the base stat. Your mutation that "let's you lift heavier objects or swing a stick harder" does not necessarily also make you tougher to damage or more disease resistant.

anoobindisguise commented 7 months ago

I'm not at all sure mutations should increase the base stat. Your mutation that "let's you lift heavier objects or swing a stick harder" does not necessarily also make you tougher to damage or more disease resistant.

so are you figuring they're increasing muscle strength in a way that doesn't increase mass or something? i assumed the mutations were causing you to grow more muscles, which should have mass of some kind.

kevingranade commented 7 months ago

Biomechanics could be adjusted, muscle efficiency could be adjusted, bulk could be adjusted but not impact lean body mass in the same way as regular muscle building. It could increase muscle mass, but the changes could be offset because it's non- human muscle mass.

ADekema commented 7 months ago

Some of the discriptions of mutations make it pretty clear that your muscle mass is visually increasing. I think the problem might be that states influence some things they shouldn´t. Strength for example shouldn´t have any impact on your discease resistance. Might want to make those things a function of health and some specific traits.

Hyperseeker commented 7 months ago

It could increase muscle mass, but the changes could be offset because it's non- human muscle mass.

Unless this non-human muscle mass is also ultralean, ultralight, absolutely-permeable, and transparent, it should either:

  1. Have the same effect as human muscle mass (which translates into base strength increase)
  2. Be described as being somehow different from what one would expect when they hear "muscle mass"

Sure, "you're now stronger" could be interpreted in a variety of ways, some of them magical, but few of them can pan out as alternatives to good ol' muscle growth without extra justifications and/or effects.

Is it muscle density? Your mass may not increase, but you should probably gain HP still because, as far as the current HP system goes, it's the amount of damage a limb can suffer being becoming unusable and requiring medical attention; denser muscles mean more/harder tissue to damage before functionality drops to 0%.

Is it tensile modulus? Probably an increase in metabolism in order to support the (likely) increased microdamage from all the stretching the muscles could do now. (Not that the game's modelling muscle growth, but, you know, reality and all that.)

Unless your muscle tissue's being replaced and/or augmented by actual alien tissue? Which sounds like a health hazard, and maybe an immune response waiting to happen.

And if that doesn't happen? I thought this game was supposed to be cosmic horror. If none of them above happens, then there's absolutely no downside to the gained strength, at least for the "human-tier" mutations such as Strong. But in this case, why doesn't Strength add mass, the one thing that makes human strength definitely-human?

What I'm saying this: the fact that some mutations which are definitely supposed to increase muscle mass don't is probably an oversight, and not something to argue over just because it's the current status quo.

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.