CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.69k stars 4.2k forks source link

Some sound hooks not playing sounds when they should #77585

Open randyk97 opened 3 weeks ago

randyk97 commented 3 weeks ago

Describe the bug

There are some sound hooks that do not play their respective sounds as defined in a JSON. All reported sound hooks have been tested with "volume" : 100, and the sound files play normally in a media player. The sound pack used is an unmodified version of Otopack (except for the volumes set to 100).

The sound hooks in question:

"id" : "chainsaw_idle", "variant" : "chainsaw_on", "id" : "melee_swing", "variant" : "chainsaw_on", "id" : "melee_hit_flesh", "variant" : "chainsaw_on", "id" : "melee_hit_metal", "variant" : "chainsaw_on", "id" : "weapon_theme", "variant" : "chainsaw", "id" : "environment", "variant" : "deafness_tone_start", "id" : "environment", "variant" : "deafness_tone_light", "id" : "environment", "variant" : "deafness_tone_medium", "id" : "environment", "variant" : "deafness_tone_heavy", "id" : "environment", "variant" : "deafness_shock",

Attach save file

N/A

Steps to reproduce

Use Otopack sound pack (https://github.com/Kenan2000/Otopack-Mods-Updates) Let chainsaw idle; attack enemy with chainsaw; smash metal tile with chainsaw Apply 'deaf' effect to oneself

Expected behavior

Sound hooks should be playing respective sounds when the volume is set to 100.

Screenshots

No response

Versions and configuration

Additional context

No response

Procyonae commented 3 weeks ago

Some of the sound hooks were hardcoded in the use action for whatever reason and were removed in https://github.com/CleverRaven/Cataclysm-DDA/commit/c5008fdd2b25bb0f793730bc589b9b1b61c8476e, they were looking to readd them in a followup PR but if they did they could well have to be called in a different way/with different ids etc. On mobile rn so I don't fancy trying to track down if they followed through or not.