search

CliMA / Oceananigans.jl

🌊 Julia software for fast, friendly, flexible, ocean-flavored fluid dynamics on CPUs and GPUs
https://clima.github.io/OceananigansDocumentation/stable
MIT License
991 stars 194 forks source link

Positive preserving WENO scheme #1173

Closed francispoulin closed 1 year ago

francispoulin commented 3 years ago

This paper shows how to define a postive preserving WENO scheme.

Very useful for ensuring positivity of tracers in general and height in a Shallow Water Model.

https://www.sciencedirect.com/science/article/pii/S0377042711002548

glwagner commented 3 years ago

Awesome. It looks like it'd require a bit of serious concentration / squinting. But hopefully the existing 5th order WENO implementation:

https://github.com/CliMA/Oceananigans.jl/blob/master/src/Advection/weno_fifth_order.jl

is helpful.

To use this we need to resolve #1015 (simple fix, but requires a bit of logic in the constructor for IncompressibleModel similar to what's done for viscosities and diffusivities) so that we can use different schemes for different fields.

navidcy commented 2 years ago

@simone-silvestri is this implemented now? should we close this?

glwagner commented 1 year ago

We have bounds preserving WENO now. @simone-silvestri open if this is closed in error.