search

ClickHouse / click-ui

The home of the ClickHouse design system and component library.
https://click-ui.vercel.app
78 stars 8 forks source link

Adding size and colour to Avatar component #464

Closed gjones closed 3 months ago

gjones commented 3 months ago

Summary

Adding the option of choosing between md and sm for the size of the Avatar. Also Adding different options for colours. Starting with 3, can add more easily later.

https://github.com/user-attachments/assets/bdab443d-8b2f-4509-a815-b3950c8ff540

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
click-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 6:29pm
rndD commented 3 months ago

What if we change the name of the component to something more generalized? CircularContainer, something like that. It seems like the element has different use cases, not avatar only.

rndD commented 3 months ago

Also additional use cases:

image

For it we need to more colors

gjones commented 3 months ago

I think that is extending Click Icon to have a backgroundColour prop.

rndD commented 3 months ago

I think that is extending Click Icon to have a backgroundColour prop.

What about a rounded shape? Should it be a custom or added to <Icon /> too?

gjones commented 3 months ago

I'll close this as the changes I made are not consistent with what an avatar actually is.