add border prop to Container

ClickHouse / click-ui

The home of the ClickHouse design system and component library.

https://click-ui.vercel.app

78 stars 8 forks source link

add border prop to Container #479

Open Kinzeng opened 2 months ago

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
click-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 16, 2024 9:49pm

gjones commented 2 months ago

Hmm I don't know about this, until now we've said that the container is for applying layouts only, an invisible element that controls the positioning of other components, so we haven't added borders, shadows, background colours etc. @vineethasok thoughts?

vineethasok commented 5 days ago

@Kinzeng @gjones I'm also against this Since we have panel I don't think we should add these to containers