search

ClickHouse / dbt-clickhouse

The Clickhouse plugin for dbt (data build tool)
Apache License 2.0
257 stars 114 forks source link

Add snapshot materialization to default settings #251

Closed BentsiLeviav closed 9 months ago

BentsiLeviav commented 9 months ago

Thanks to the test test_snapshot_check_cols.TestSnapshotCheckCols I found out I didn't add all materializations when changing default settings in #250

genzgd commented 9 months ago

Tests still aren't passing?

BentsiLeviav commented 9 months ago

@genzgd While trying to solve #246, I found out test_snapshot_check_cols.TestSnapshotCheckCols fails as well (due to the changes I made in #231.

genzgd commented 9 months ago

Understood, I meant that even with this fix the test suite still isn't passing. That is on me, I shouldn't have approved #231 but I missed that tests were also failing there.

One problem is, like snapshot, it looks like 'distributed_table' also isn't covered by the new settings code. Even when I tried adding that locally I got test failures, so we need to dig a little deeper before releasing again.