ClickHouse / dbt-clickhouse

The Clickhouse plugin for dbt (data build tool)
Apache License 2.0
245 stars 100 forks source link

feat: support query_settings in view materialization #324

Closed james-seymour-cubiko closed 2 months ago

james-seymour-cubiko commented 2 months ago

Summary

Currently the settings configuration option is used when creating a view, but only at view creation time. These settings do not persist when actually querying the view, so this PR adds the option to use the separate query_settings config option to create a view with settings that persist at query time.

My specific use case is to allow join_use_nulls=1 to be set within dbt, rather than remembering to include this setting every time I query the view.

I'm a first timer here, so have a few questions too,

BentsiLeviav commented 2 months ago

Hi @james-seymour-cubiko Thanks for your contribution!

Per your question, I don't see any particular test that includes this change. Regarding the issue - it is ok, you don't have to create one.

I ran the tests and all passed, therefore I'm merging this change.