search

Clickism / ClickVillagers

A simple 1.20 plugin that makes handling villagers a lot easier.
Other
4 stars 2 forks source link

[Request] Stop using inventory titles #15

Closed QarthO closed 8 months ago

QarthO commented 9 months ago

In your code, you're using inventory titles to check if the villager is a clickvillager. This should be avoided as it can easily be exploitable, (players can easily rename inventories and trick your plugin into thinking it was a click villager)

You should look into inventory holders, and then check if the inventory is an instanceof your custom inventory holder

Clickism commented 8 months ago

Thanks, I will look into this. Inventory holders seem to be bad for performance and a misuse of the API. But I'm currently working on another solution along with an update for ClickShop.