Clinical-Genomics / genmod

Annotate models of genetic inheritance patterns in variant files (vcf files)
http://Clinical-Genomics.github.io/genmod/
MIT License
78 stars 19 forks source link

Ensure chrX and X are treated equally #135

Closed fellen31 closed 1 month ago

fellen31 commented 2 months ago

Description

Closes #132.

Adds a VCF file with chr prefix, and a test to check that models are equal between both files. I don't know that much python/pytest so let me know if the code can be improved.

Added

-

Changed

-

Fixed

How to prepare for test

How to test

Expected test outcome

Review

This version is a

Implementation Plan

fellen31 commented 1 month ago

I don't think I have enough experience with pytest yet @torbjorgen to fully understand how to best solve this. I don't want to make the codebase worse, but I also know this project is not a priority.

Is moving the common functions to a test_utils.py an okay middle way to reduce code duplication without dealing with pytest fixtures?