Release restriction on Python 3.8 (collections import) - Githubissues

Clinical-Genomics / genmod

Annotate models of genetic inheritance patterns in variant files (vcf files)

http://Clinical-Genomics.github.io/genmod/

MIT License

78 stars 19 forks source link

Release restriction on Python 3.8 (collections import) #142

Closed dnil closed 3 weeks ago

dnil commented 1 month ago

Description

release restrictions on newer versions of python (collections import) and update tests, workflows to 3.12

How to prepare for test

[ ] Ssh to relevant server (depending on type of change)
[ ] Use stage: us
[ ] Paxa the environment: paxa

[ ] Install on stage (example for Hasta):

bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_[TOOL]-t [TOOL] -b [THIS-BRANCH-NAME] -a

How to test

[ ] Do ...

Expected test outcome

[ ] Check that ...
[ ] Take a screenshot and attach or copy/paste the output.

Review

[ ] Tests executed by
[ ] "Merge and deploy" approved by Thanks for filling in who performed the code review and the test!

This version is a

[ ] MAJOR - when you make incompatible API changes
[ ] MINOR - when you add functionality in a backwards compatible manner
[x] PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

[ ] Document in ...
[ ] Deploy this branch on ...
[ ] Inform to ...

dnil commented 1 month ago

Well, and here I was saying to myself, echoing what previous speakers have said: we should migrate install to poetry as we move to 3.8. But then I went, let's just leave 3.8 first, and do poetry separately not to change too much. Famous last words. But here we are.

free from constraints on 3.8
3.13 in tests and docker
still on setup, so should not affect any deploy automation or such