Clinical-Genomics / preClinVar

A ClinVar API submission helper written in FastAPI
MIT License
1 stars 0 forks source link

Add tests for validate and dry-run endpoints #33

Closed northwestwitch closed 2 years ago

northwestwitch commented 2 years ago

This PR adds | fixes:

Review:

This version is a:

codecov-commenter commented 2 years ago

Codecov Report

Base: 93.86% // Head: 97.88% // Increases project coverage by +4.01% :tada:

Coverage data is based on head (bd47d2d) compared to base (db25514). Patch coverage: 98.83% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== + Coverage 93.86% 97.88% +4.01% ========================================== Files 7 8 +1 Lines 163 236 +73 ========================================== + Hits 153 231 +78 + Misses 10 5 -5 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `97.88% <98.83%> (+4.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics) | Coverage Δ | | |---|---|---| | [preClinVar/csv\_parser.py](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#diff-cHJlQ2xpblZhci9jc3ZfcGFyc2VyLnB5) | `97.97% <92.30%> (ø)` | | | [preClinVar/build.py](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#diff-cHJlQ2xpblZhci9idWlsZC5weQ==) | `100.00% <100.00%> (ø)` | | | [preClinVar/constants.py](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#diff-cHJlQ2xpblZhci9jb25zdGFudHMucHk=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: | | [preClinVar/demo/\_\_init\_\_.py](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#diff-cHJlQ2xpblZhci9kZW1vL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [preClinVar/main.py](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#diff-cHJlQ2xpblZhci9tYWluLnB5) | `94.54% <100.00%> (+10.76%)` | :arrow_up: | | [tests/test\_main.py](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#diff-dGVzdHMvdGVzdF9tYWluLnB5) | `100.00% <100.00%> (ø)` | | | [preClinVar/validate.py](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#diff-cHJlQ2xpblZhci92YWxpZGF0ZS5weQ==) | `100.00% <0.00%> (+7.69%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.