search

Clinical-Genomics / scout

VCF visualization interface
https://clinical-genomics.github.io/scout
BSD 3-Clause "New" or "Revised" License
152 stars 46 forks source link

Visual cue for clinical filter #3011

Open 47KW opened 2 years ago

47KW commented 2 years ago

Hello, I would like to suggest a visual cue for clinical filter being active in SNV Indel list-view. Maybe something like a green phrame?

dnil commented 2 years ago

Could be doable. More in general, what benefit for the user are you trying to achieve with it?

Is it that you want to be sure you have pressed it and not seeing other stuff, or that you want to be aware that you are seeing less than all variants, or something else?

47KW commented 2 years ago

It is to get visual aid that it is active. Sometimes we miss it, a minor improvement. So depending on how difficult it is to make…? Some people wanted a green lepricon with a sign saying “Clinical”. I just think it is too much?

/ Håkan

Från: Daniel Nilsson @.> Skickat: den 2 december 2021 13:53 Till: Clinical-Genomics/scout @.> Kopia: Håkan Thonberg @.>; Author @.> Ämne: Re: [Clinical-Genomics/scout] Visual cue for clinical filter (Issue #3011)

Could be doable. More in general, what benefit for the user are you trying to achieve with it?

Is it that you want to be sure you have pressed it and not seeing other stuff, or that you want to be aware that you are seeing less than all variants, or something else?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Clinical-Genomics/scout/issues/3011#issuecomment-984600600, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALIHQ4RRQUL2BCS2T6OZP5TUO5T3JANCNFSM5JHBCXGQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

dnil commented 2 years ago

Leprecauns are fun! I'm not against it, just want to understand why to make a good implementation. The two scenarios above would call for somewhat different code. Thing is there is currently no such thing in the code as "clinical filter being active", only that the user just pressed the "clinical filter" button. After that, it's currently just like any filter.