Closed dnil closed 2 weeks ago
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.76%. Comparing base (
1a81fe4
) to head (4549e02
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Mm, I think this is more or less ok with this, and then we can improve a bit further when we start getting CLNSIGCONF
parsed in from the pipelines.
I worry about the conflicting variants not being up there with a clinical filter grade REVSTAT
, but running the numbers make me feel a little better:
The number of conflict status vars with a P/LP classification in the mix is larger than one would desire (17k) but compared to the total of 1.1M variants it's not a huge issue. I'm sure this will bite on a case here and there, but for the bulk it means less needless clicks over to clinvar.
EDIT: latest ClinVar ref dump numbers
https://github.com/Clinical-Genomics/scout/blob/02b3dc50bb37c47aef97daba46d7958f27ce73f7/scout/build/variant/clnsig.py#L18 The loading logs must be rather crowded. I do so wish we had a regular log audit, or at least someone from prod to notify us when something happens in the warnings/errors department. There is something to crashing early.. 😁
This PR adds a functionality or fixes a bug.
Testing on cg-vm1 server (Clinical Genomics Stockholm)
**Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `sshTesting on hasta server (Clinical Genomics Stockholm)
**Prepare for testing** 1. `sshHow to test:
Expected outcome: The functionality should be working Take a screenshot and attach or copy/paste the output.
Review: