Remove crossplatform option

seallard commented 1 month ago

Description

The containerization software we run on the cluster (Singularity) cannot run images generated with the buildx option. It throws errors like unsupported schema version 2. This is due to the software being outdated by 5 years.

The issue is resolved by removing buildx (it lets you build images for both arm64 and amd64 architectures). We only use amd64 on our servers.

The only drawback is that our Macs use arm64, meaning that the images will not be possible to run on our local machines. I can sidestep this by reintroducing the duplication and have a separate one for the CLI images intended to run on the cluster. I'm fine with either option. I don't think anyone in our team uses the web API image locally anyway.

Fixed

Remove buildx option breaking old containerization software on cluster

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

seallard commented 1 month ago

I don't think the container needs to be able to run on our macs. I'm a bit confused though. I can't find any arm64 containers on dockerhub. Do we not push them?

I dug around and you are correct, is seems like the default --platform option with buildx is taken from the environment the builds is done in. So currently, we only build for linux/amd64 if I understand the docs correctly.

If we do want to build for arm64, we would need buildx and specify arm64 as an additional platform to build for.

Clinical-Genomics / trailblazer