Clon1998 / mobileraker

A Flutter mobile app for Klipper/Moonraker
Other
490 stars 56 forks source link

Constant Notifications while printing (iOS) #38

Closed edddeduck closed 2 years ago

edddeduck commented 2 years ago

Describe the bug When printing you get notifications every second from the app.

To Reproduce Steps to reproduce the behavior:

  1. Open the app then start a print on the printer
  2. Notice you start to get notifications every second.

Expected behaviour You would expect to get notifications at key progression points or after set amounts of time.

Screenshots N/A

Smartphone (please complete the following information):

This doesn't seem to be device specific but below is the hardware I have been using.

**Mobileraker-Version Test Flight 1.4.1 (1.4.1.0)

Additional context

natewalck commented 2 years ago

I am also seeing this as described above.

iOS 15.3.1

Clon1998 commented 2 years ago

Thanks for the feedback. After some investigation, I found out that this is caused by the used notification library. The print progress notification is supposed to be a progress bar/progress notification. However, the library does not support progress bar notifications for iOS yet and therefore creates normal messages. Because of that I disabled local notification handling for IOS and removed the progress notification for iOS for now in 79c22fa5f7d6a547f1d8402fe4b540ccd68125ea. However, state update notifications like print start, error, print finished should still be shown.

Clon1998 commented 2 years ago

@jniebuhr submitted a new version to TestFlight that should fix this issue. Please let me know if it works in v 1.4.2

Clon1998 commented 2 years ago

Fixed with 1.6.2