search

Cloud-CV / Fabrik

:factory: Collaboratively build, visualize, and design neural nets in browser
GNU General Public License v3.0
1.12k stars 235 forks source link

Feature Request: Add a new section in Model Zoo for Generation #489

Open rahulsnkr opened 5 years ago

rahulsnkr commented 5 years ago

Generative Adversarial Networks (GANs) have gained a lot of traction, both from research point of view, as well as development, due to their numerous applications. A lot of GAN architectures have also been published, for example -

Therefore, it makes sense to have a separate section for Generation in the Model Zoo, and GAN architectures could be added within that section

I'd like to work on this, starting with Vanilla GAN

Ram81 commented 5 years ago

@rahulsnkr sure go ahead

rahulsnkr commented 5 years ago

At the moment, Fabrik is not capable of importing/exporting two networks at the same time, and the given issue is dependent on the same, since a GAN consists of two networks, i.e. a generator and a discriminator. How should I proceed from here? Should I try to add support for Fabrik so that it is capable of supporting more than one network? @Ram81

thatbrguy commented 5 years ago

@rahulsnkr In my opinion supporting more than one network does not sound like a good idea. Other than massive UI redesign, we also have to take care of proper usage of graphs and sessions in Keras and TF.

Instead of that, we can just use Generators and Discriminators separately. To be honest, most Generators are variants of U-Nets and Autoencoders. Similarly, Discriminators are straightforward too, except for some like the PatchGAN. Keeping Generators and Discriminators separate would also allow you to mix and match combinations.

What you can do instead is while exporting a Generator we could have a popup that allows you to download a Discriminator as well. We can also have toy code samples to enable loading a GAN and using them. @Ram81 What do you think?

rahulsnkr commented 5 years ago

@thatbrguy yes that seems like a much better idea. It will also give the users more flexibility. Maybe the 'Generation' section can have two subsections for generators and discriminators, and as you said, the user can be prompted to download a discriminator when exporting a generator, and vice versa. @Ram81 does this sound ok?

kartikdutt18 commented 5 years ago

@rahulsnkr @Ram81 If generators and discriminators are made available separately, Can I work on DCGAN ?

Ram81 commented 5 years ago

@rahulsnkr can you research if it's feasible to have multiple model in fabrik's current implementation. If it is not feasible then we can go ahead with some other approach

rahulsnkr commented 5 years ago

@Ram81 i'll look into it!

rohanasthana commented 5 years ago

Is this still open? I would like to work on this issue