search

Cloud-CV / Fabrik

:factory: Collaboratively build, visualize, and design neural nets in browser
GNU General Public License v3.0
1.12k stars 235 forks source link

Share Model URL fix #496

Closed sayamkanwar closed 5 years ago

sayamkanwar commented 5 years ago

Hi, I have fixed the bug in the share model feature which generated different URLs every time. Now it generates only one URL for a model.

Here's a demo

share_patch

Please review @Ram81 @RishabhJain2018 Thank you! :)

Ram81 commented 5 years ago

@sayamkanwar how is this different from your work in #477 ?

sayamkanwar commented 5 years ago

Hi @Ram81, In #477, on clicking the share button multiple times it created a new network version in the history and it showed multiple ‘Shared Model’ entries earlier, now that has been corrected too.

sayamkanwar commented 5 years ago

Also @Ram81, what else does the task demand? Wasn’t that the only correction in this task?

sayamkanwar commented 5 years ago

@Ram81, I'm sorry I had to abandon this task as I could not understand what to do in this. But I would like to work on this after the contest too.

Ram81 commented 5 years ago

Closing this as student has abandoned the task