search

CloudSlang / atom-cloudslang-package

Atom package for CloudSlang support
Apache License 2.0
7 stars 3 forks source link

CS icon on atom dark theme #53

Closed levice14 closed 8 years ago

levice14 commented 8 years ago

CS icon is not visible on the black theme - by @lrevnic

cs_icon

SamMarkowitz commented 8 years ago

Atom takes the image from the CloudSlang GitHub page and the font color of the text is very close to the background color. I changed the background there to be white instead of transparent so the text will always show against a white background. Makes it look a little less pretty in GitHub: https://github.com/CloudSlang.

@meshipeer and whoever else feels like weighing in: Is that alright?

meshipeer commented 8 years ago

cant we configure the background color?

SamMarkowitz commented 8 years ago

Where?

In Atom we can't change the user's settings for their theme, so if we use an image with a transparency, we'll never know what background color it will be up against.

That leaves us with filling in the background color in the image itself so it will always stand out. That same image will appear in Atom and on GitHub. We can choose whatever background we want for that.

SamMarkowitz commented 8 years ago

Changed GitHub image.