search

Cloudkibo / KiboPush

0 stars 1 forks source link

Modify client side code to allow actions as per user permissions #9218

Open ImranBinShoukat opened 4 years ago

ImranBinShoukat commented 4 years ago

In this task, we will modify client side code to allow actions as per user permissions. If user is not permitted to perform such action then we will not show him that action.

jekram commented 4 years ago

@ImranBinShoukat I thought we already have that? Is this an audit? I remember @arveenkumar55 testing this?

We should also disable from UI. There is no point in showing Agent a function and then not allowing it.

ImranBinShoukat commented 4 years ago

We have disabled the actions from the UI but that is not table driven. We have made the checks on client side and if we change any permission in the table then it won't affect our UI. In this task, I will make it table driven. So our UI will get the permissions from server and then check if the user is allowed to perform the action. That way if some permission gets changes in the table then it will be affected on client side as well

ImranBinShoukat commented 4 years ago

Work on this task has been completed. Assigning @AnishaChhatwani to test this

AnishaChhatwani commented 4 years ago

Tested locally

AnishaChhatwani commented 4 years ago

Tested on staging