IPaddr2: improve fail logic and check ip_status after adding IP

ClusterLabs / resource-agents

Combined repository of OCF agents from the RHCS and Linux-HA projects

GNU General Public License v2.0

493 stars 582 forks source link

IPaddr2: improve fail logic and check ip_status after adding IP #1985

Closed oalbrigt closed 1 month ago

oalbrigt commented 1 month ago

check that the label got applied
return OCF_ERR_GENERIC to avoid false-positive when IP was manually added before starting the resource
check ip_status after adding IP to fail without having to wait for the first monitor-action

oalbrigt commented 1 month ago

Based on https://github.com/ClusterLabs/resource-agents/pull/1982

karcaw commented 1 month ago

the best way we have to reproduce this is to have one label and IP on an Infiniband ipoib interface, and then try to add a second IP and label on the same interface. the second one seems to not get a label at times. This does not happen on our ethernet interfaces. this is in an active/active failover pair, and so we have two IPs and in a failover situation, we just don't get the label. a dependent resource is looking for that label for binding and fails.

oalbrigt commented 1 month ago

Thanks for the instructions on how to reproduce the issue.