search

ClusterM / usb-serial-telnet-server

Android application that binds a USB serial converter to a Telnet client
GNU General Public License v3.0
56 stars 8 forks source link

Reproducible Builds #9

Closed IzzySoft closed 1 month ago

IzzySoft commented 4 months ago

I've checked your app if its build is reproducible (see: Reproducible bulds, special client support and more in our repo), but while I was able to successfully generate the APK using ./gradlew assembleRelease, it didn't match yours. According to the diff in the AndroidManifest.xml, your APK cannot have been built from the commit the tag points to:

-    A: http://schemas.android.com/apk/res/android:versionCode(0x0101021b)=9
+    A: http://schemas.android.com/apk/res/android:versionCode(0x0101021b)=8

Looks rather like some uncommitted change, as even the manifest at the current HEAD still has versionCode: 8.

Could you please push the commit you've built from, and let me know what commit hash it is? And ideally, with future releases build the APK from a clean tree at the commit the tag points to? Thanks in advance!

PS: some more hints on increasing chances for a reproducible build can be found with our hints on reproducible builds in the IzzyOnDroid wiki :wink:

ClusterM commented 4 months ago

Fixed, thank you.

IzzySoft commented 3 months ago

Thanks! But: fixed how? Which commit is it I'd need to build the app from so it would be identical? I see the versioning is fixed in the latest commit now. So I guess I shall wait for the next release then to retry? Just need to know :wink:

IzzySoft commented 3 months ago

@ClusterM Any ETA for said release?

IzzySoft commented 3 months ago

@ClusterM any word?

ClusterM commented 2 months ago

@IzzySoft Sorry for not so fast answer. Check it now. It's 100% the same code used to build release.

IzzySoft commented 1 month ago

Thanks Alexey! This time it's me who has to apologize for the delay (I've been on vacation for the last 3 weeks). Seeing there were some new releases, I gave the latest one (v1.7) a try – and congrats, you made it! Here comes your welcome toot

image

and maybe you want to pick a badge to link to your app at IzzyOnDroid e.g. from the Readme?