search

CnCNet / cncnet-yr-client-package

The official CnCNet Yuri's Revenge package for online.
https://cncnet.org/yuris-revenge
GNU General Public License v3.0
105 stars 31 forks source link

Fix return to live version #329

Closed Belonit closed 10 months ago

Belonit commented 10 months ago

I'd like to point out that this should be a temporary fix. I think ideally, we want the updater to compare the contents of the version files for previous version and incoming version and delete and that are deemed "extra" from previous.

I think we can't delete "extra" files for the game's root directory, since it is difficult to determine what exactly is "extra"

devo1929 commented 10 months ago

I'd like to point out that this should be a temporary fix. I think ideally, we want the updater to compare the contents of the version files for previous version and incoming version and delete and that are deemed "extra" from previous.

I think we can't delete "extra" files for the game's root directory, since it is difficult to determine what exactly is "extra"

I think the updater should have the ability to determine what's extra. I believe it already uses the current version file (before updating) and the version file that's IN the update to determine what files to pull down exactly during the update. I believe it does so by seeing which files exist in the new version file, but not the old as well as comparing hashes of files that exist in both. We should be able to create an additional check for files the exist in the old version file but NOT in the new and then delete what it finds.