Cockatrice / Magic-Token

Tokens.xml for M:tG
The Unlicense
11 stars 15 forks source link

MTGJSON as source & automated building #232

Open tooomm opened 1 year ago

tooomm commented 1 year ago

Dropping a thought here: MTGJSON has token cards, and with the last release (5.2.1) there are also information on related cards.

The data should be from Scryfall as well. We could build the database automatically rather than trying to keep up manually, similar to our spoiler files.

For the future, once Oracle is not used anymore and there are ready-to-use, MTGJSON sourced card databases for Cockatrice, tokens can maybe be part of it as well.

SlightlyCircuitous commented 1 year ago

Sounds like it could be very useful. However, how would this work with token images that aren't on Scryfall? would they need special logic to pull the images from other sources?

tooomm commented 1 year ago

Don't mostly all new tokens have art?

And for the old or custom ones we have the data ready in the current file. Or a new, simple mapping file for such cases maybe? When I think about the earlier spoiler takes, there were also additional files that the script consumed for corrections and adding missing cards.

SlightlyCircuitous commented 1 year ago

So, we would have a manually curated file of tokens that don't have scryfall/gatherer art alongside the automatically generated file from MTGJSON and then stitch those two together for the tokens file for Cockatrice?

SlightlyCircuitous commented 1 year ago

also, yes, most new tokens have art, although for whatever reason Jumpstart '22 tokens didn't have art at all