search

CocoaPods / Xcodeproj

Create and modify Xcode projects from Ruby.
http://rubygems.org/gems/xcodeproj
MIT License
2.36k stars 458 forks source link

[Internal] Add a Dangerfile to this repo #381

Open AliSoftware opened 8 years ago

AliSoftware commented 8 years ago

Especially so that we ensure every PR has a CHANGELOG entry and correctly formatted (with full stop + 2 spaces + link to author & PR, etc)

\cc @orta

orta commented 8 years ago

You can grab the ENV token from the top of this build, then you ideally want the same Dangerfile as CocoaPods. It should take ~10m to set up, worth doing yourself. You need to add it to the gemfile and run bundle exec danger init ( and giving me feedback )

segiddins commented 8 years ago

Maybe we want to make a CocoaPods danger plugin to centralize all our configuration across repos?

orta commented 8 years ago

IMO, I think that's probably for the best, I've just shipped 0.8 with the new plugins support, looks like https://github.com/dbgrandi/danger-proselint/blob/master/lib/danger_plugin.rb

We're still a bit off making danger plugin create

AliSoftware commented 8 years ago

Yeah about integration I was planning about trying to do that myself as I've never done it before and would be interested to learn how to do it so that would be a good occasion :wink: (But as my TODO list is already full I wanted to log the issue to be sure not to forget about it)

I pinged @orta just because I wonder if we already have a Danger file doing all that (not just checking for a CHANGELOG change but also checking the syntax and full-stop-two-spaces etc) and as I know we considered generalizing that solution (like a plugin dedicated to CHANGELOG checks?)