Don't raise an exception on newer Xcode than latest known

CocoaPods / Xcodeproj

Create and modify Xcode projects from Ruby.

http://rubygems.org/gems/xcodeproj

MIT License

2.37k stars 458 forks source link

Don't raise an exception on newer Xcode than latest known #953

Closed Kaspik closed 4 months ago

Kaspik commented 4 months ago

remove exception on newer Xcode version and log only warning to inform user they are using newer xcode than the latest supported by xcodeproj - if things don't work, it will fail automatically on the right place - but chance is newer Xcode simply works so there is no reason why users should be blocked by outdated xcodeproj

Fixes issues like https://github.com/CocoaPods/Xcodeproj/issues/933 where fix is merged in but still not released and users are blocked for months.

orta commented 4 months ago

Can you switch this around to a warning please (and make it a bit more human friendly), and I'll get this merged - I think it's the right thing to do at this point

orta commented 4 months ago

There's also the one above, which might need it too?

Kaspik commented 4 months ago

Happy to do so! (once I find out how I throw warning 😃 )

Kaspik commented 4 months ago

Update to puts with a WARN: prefix

orta commented 4 months ago

We use UI.warn - https://github.com/CocoaPods/Xcodeproj/blob/fe55cf57badef2ca27fb9d4f801d9b834de1f871/lib/xcodeproj/project/object.rb#L321C13-L321C22 which should make it consistent with other stuff (I'd offer a suggestion but there could be lint issues from it )

Kaspik commented 4 months ago

Thanks, done! ✅

Kaspik commented 4 months ago

@orta Once this gets out, any chance we could do a release? Not only for this, but the CVE-Vulnerability fix should also get out finally. :)

orta commented 4 months ago

That is more complex and out of my hands to commit to I'm afraid, but I'd like to see it happen too

Kaspik commented 4 months ago

Understand, let's merge this and we will see how others feel about a new release.