search

Code-Hex / graphql-codegen-typescript-validation-schema

GraphQL Code Generator plugin to generate form validation schema from your GraphQL schema
MIT License
316 stars 42 forks source link

fix(enum): propagate namingConvention.transformUnderscore to convertNameParts #828

Closed sutt0n closed 3 weeks ago

sutt0n commented 2 months ago

When I introduced useEnumTypeAsDefaultValue via #640, I failed to propagate this prop down and this resulted in no control over underscores.

Docs are also updated.

sutt0n commented 2 months ago

@Code-Hex I believe that job is failing since the action is running against my fork, and not your repository; thus the ref to fix/name-parts doesn't exist.

KamalAman commented 2 months ago

+1 this PR, I just ran into these issues

sutt0n commented 1 month ago

@Code-Hex This is ready for your review at your convenience. 🙏

sutt0n commented 1 month ago

@Code-Hex Howdy, apologies for the double ping -- hope all is well with you! Just wanting to be sure to bump this, as others are having this same issue.

Code-Hex commented 3 weeks ago

I can handle it 🙏