Aboutus

[affilnost]

@susendeep In this commit bb54c3f62415671f14919304e7a743e62e9419c3 you added bootstrap.min.css to the whole project, and it broke the footer elements alignment. Please see the screenshot attached.

[susendeep]

I'm working on footer page and will fix it.

On Fri, Mar 23, 2018 at 10:12 PM, Anastasiia notifications@github.com wrote:

@susendeep https://github.com/susendeep In this commit bb54c3f https://github.com/Code4SocialGood/c4sg-web/commit/bb54c3f62415671f14919304e7a743e62e9419c3 you added bootstrap.min.css to the whole project, and it broke the footer elements alignment. Please see the screenshot attached.

[image: footer margin bug] https://user-images.githubusercontent.com/2981884/37841903-11c1a328-2ec1-11e8-874a-e2d0764c3a9e.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Code4SocialGood/c4sg-web/pull/1815#issuecomment-375727394, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae-lTckglaZ50NVSurk8HPIFxT0jyfCuks5thSXcgaJpZM4SW5HM .

-- https://www.somaiya.edu http://www.somaiya-ayurvihar.org
http://nareshwadi.org http://somaiya.com http://www.helpachild.in
http://nareshwadi.org

[affilnost]

@susendeep I've also noticed that after that commit (bb54c3f) the "Location" and "Badges" labels are not visible ("appreciations" page), cause in bootstrap's css they have the color "#fff". And also there's an error in console after that commit. Please see the screenshot attached.

[affilnost]

@susendeep Another issue which occurred after adding bootstrap's css (commit bb54c3f) is the incorrect css in the Volunteer User page. Some marging are incorrect, and the "info" block has a grey background and border. Please see the screenshot attached. Is it necessary to add bootstrap.min.css to the whole project? Cause it causes risks of broken css in multiple places. Maybe it makes sense to add bootstrap.min.css just to the "Aboutus" page?

[susendeep]

I'm a bootstrap volunteer and I'm doing this via permission from Jenny.Bootstrap file needs to be included in index page as Code for Social Good is getting converted from present material design to Bootstrap CSS framework and conversion do require time and hence I'm doing it page by page.

Thank you for bringing such issues to notice.

On Sun, Mar 25, 2018 at 8:58 PM, Anastasiia Antonova < notifications@github.com> wrote:

@susendeep https://github.com/susendeep Another issue which occurred after adding bootstrap's css (commit bb54c3f https://github.com/Code4SocialGood/c4sg-web/commit/bb54c3f62415671f14919304e7a743e62e9419c3) is the incorrect css in the Volunteer User page. Some marging are incorrect, and the "info" block has a grey background and border. Please see the screenshot attached. Is it necessary to add bootstrap.min.css to the whole project? Cause it causes risks of broken css in multiple places. Maybe it makes sense to add bootstrap.min.css just to the "Aboutus" page? [image: additional_bugs] https://user-images.githubusercontent.com/2981884/37876770-c413b714-3051-11e8-96ab-b902d962caa7.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Code4SocialGood/c4sg-web/pull/1815#issuecomment-375978934, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae-lTbrHroCB_OAbzWGzwztot9jSSXv1ks5th7eQgaJpZM4SW5HM .

--

https://www.somaiya.edu http://www.somaiya-ayurvihar.org
http://nareshwadi.org http://somaiya.com http://www.helpachild.in
http://nareshwadi.org

[susendeep]

Hi,

I'd fixed the issues raised by you and had submitted it to Github owner and see to reflect changes.

On Mon, Mar 26, 2018 at 8:15 PM, SUSENDEEP DUTTA susendeep.d@somaiya.edu wrote:

I'm a bootstrap volunteer and I'm doing this via permission from Jenny.Bootstrap file needs to be included in index page as Code for Social Good is getting converted from present material design to Bootstrap CSS framework and conversion do require time and hence I'm doing it page by page.

Thank you for bringing such issues to notice.

On Sun, Mar 25, 2018 at 8:58 PM, Anastasiia Antonova < notifications@github.com> wrote:

@susendeep https://github.com/susendeep Another issue which occurred after adding bootstrap's css (commit bb54c3f https://github.com/Code4SocialGood/c4sg-web/commit/bb54c3f62415671f14919304e7a743e62e9419c3) is the incorrect css in the Volunteer User page. Some marging are incorrect, and the "info" block has a grey background and border. Please see the screenshot attached. Is it necessary to add bootstrap.min.css to the whole project? Cause it causes risks of broken css in multiple places. Maybe it makes sense to add bootstrap.min.css just to the "Aboutus" page? [image: additional_bugs] https://user-images.githubusercontent.com/2981884/37876770-c413b714-3051-11e8-96ab-b902d962caa7.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Code4SocialGood/c4sg-web/pull/1815#issuecomment-375978934, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae-lTbrHroCB_OAbzWGzwztot9jSSXv1ks5th7eQgaJpZM4SW5HM .

--

https://www.somaiya.edu        http://www.somaiya-ayurvihar.org  http://nareshwadi.org  http://somaiya.com  http://www.helpachild.in  http://nareshwadi.org

[affilnost]

@susendeep great, thank you! :)