Support showing ctrl, alt, win keys pressed down without any other key

Code52 / carnac

A utility to give some insight into how you use your keyboard

http://carnackeys.com/

Microsoft Public License

4.2k stars 506 forks source link

Support showing ctrl, alt, win keys pressed down without any other key #160

Open bfritscher opened 7 years ago

bfritscher commented 7 years ago

Removed filtering of modifierkey to allow to handle them in ToInputs.
Filtered triggering of modifier display for modifierkeys themselves in ToInputs.
Exposed IsModifierKeyPress as static to be used in KeyPress and Messages.
KeyPress.HasModifierPress returns false if key is a modifierkey itself (allow the merging in Message).
Message disable repeat counting incrementing for modifierkeys themself, but still handling their repeat, in order for them to keep showing while keydown.

This should partially solve issue #154 Note sure about the sticky key part on mac.

bfritscher commented 7 years ago

after integrating it with my other changes i found there are bugs, and found another solution, but it now seems to fail the tests :-(

But a side effect is that it now support issue #76

hnrkndrssn commented 7 years ago

Hey @bfritscher,

I haven't forgotten about your PRs, I've just been busy with some other things lately. I should have some time over the next week or so to sit down and review your PRs.

My apologies for the delay in getting to them!

Thanks, henrik

bfritscher commented 7 years ago

@alfhenrik No problems :-) And I understand that they are a bit more complex. They also might need some test cases, in order to cover edge cases. Happy to do some changes after your insights. Best regards, Boris

king3dward commented 6 years ago

To solve this issue would be so helpful, to show CTRL SHIFT stand alone. Any progress maybe?

clragon commented 5 years ago

I was looking to get a counter on the modifier keys specifically, but there seems no option to do so...

Benbinbin commented 4 years ago

Removed filtering of modifierkey to allow to handle them in ToInputs.

Filtered triggering of modifier display for modifierkeys themselves in ToInputs.

Exposed IsModifierKeyPress as static to be used in KeyPress and Messages.

KeyPress.HasModifierPress returns false if key is a modifierkey itself (allow the merging in Message).

Message disable repeat counting incrementing for modifierkeys themself, but still handling their repeat, in order for them to keep showing while keydown.

This should partially solve issue #154 Note sure about the sticky key part on mac.

Hi, @bfritscher I really appreciate your work to add the mouse highlight, but the https://github.com/bfritscher/carnac/tree/v3-beta seem have a bug, like #173 descripe, when hold two keys and left click, but it dosen't show any key just the mouse icon.

crutchcorn commented 3 years ago

Any possibility of getting this merged?