search

CodeCrafter47 / BungeeTabListPlus

GNU General Public License v3.0
149 stars 69 forks source link

1.8 client crash (possible <1.13) #738

Open andreasdc opened 1 year ago

andreasdc commented 1 year ago

The latest version crashes 1.8 client and I guess all below 1.13 [12:05:37] [Client thread/FATAL]: Unreported exception thrown! java.lang.NullPointerException: Cannot invoke "a.b()" because the return value of "aul.l()" is null at avo.a(SourceFile:276) ~[minecraft-1.8.8-client.jar:?] at bfk.a(SourceFile:1021) ~[minecraft-1.8.8-client.jar:?] at ave.av(SourceFile:915) ~[minecraft-1.8.8-client.jar:?] at ave.a(SourceFile:325) [minecraft-1.8.8-client.jar:?] at net.minecraft.client.main.Main.main(SourceFile:124) [minecraft-1.8.8-client.jar:?] at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) ~[?:?] at java.base/java.lang.reflect.Method.invoke(Method.java:578) ~[?:?] at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:243) [NewLaunch.jar:?] at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:278) [NewLaunch.jar:?] at org.multimc.EntryPoint.listen(EntryPoint.java:143) [NewLaunch.jar:?] at org.multimc.EntryPoint.main(EntryPoint.java:34) [NewLaunch.jar:?]

Andre601 commented 1 year ago

Nothing in that stacktrace even remotely hints at BTLP being the issue, so what makes you think that?

andreasdc commented 1 year ago

Nothing in that stacktrace even remotely hints at BTLP being the issue, so what makes you think that?

Because I checked that and I'm 100% sure. Simply disabling the tablists allow users to join without crashing. Somewhere probably needs to be a string, not BaseComponent. Remember that it's client crash.

Andre601 commented 1 year ago

That doesn't proof anything.

This stacktrace doesn't make sense for a proxy, so I assume it's from your client logs? I then want to say to please check your proxy logs for errors.

andreasdc commented 1 year ago

It is client crash. No errors on the proxy. I am 100% sure that it's BTLP's issue.

Andre601 commented 1 year ago

Without any errors on proxy by btlp I doubt it is.

Errors caused by plugins on a proxy usually also show errors.

Please share your proxy's full latest.log through https://mclo.gs

andreasdc commented 1 year ago

I already told you, if you still don't believe me, you can check that by yourself. Sending wrong data to the client will result in a client crash, not plugin side error.

Andre601 commented 1 year ago

As long as you're not providing any data to work with (proxy type and build, client version, etc.) we can't and won't help. You are expected to give the least amount of work here.

So, instead of excuses, just provide the logs I asked you for already.

andreasdc commented 1 year ago

The latest bungeecord. The lastest BTLP. Have any tablist. Join with 1.8 and probably any version below 1.13. You get the crash. If you need more, check that by yourself, I assured you more than 3 times. No errors on the proxy, I gave you crash from the client. Probably here and maybe in the other places you need to check the protocol version and send either the string or the BaseComponent. https://github.com/CodeCrafter47/BungeeTabListPlus/blob/9c56d1b048ebff69837bf402025838690b8d5674/bungee/src/main/java/codecrafter47/bungeetablistplus/handler/AbstractLegacyTabOverlayHandler.java#L437C1-L437C1

Andre601 commented 1 year ago

And I told you 3 times now to give the logs of the proxy because client logs do absolutely nothing for us.

Also, make sure to join with latest 1.8 (1.8.9 iirc) since there were major changes between it and older 1.8 versions.

andreasdc commented 1 year ago

I told you what happens, I told you because of what, I already gave you everything that you wanted. I can't wait for the fix so I can update BTLP and bungee again. 🚀

Andre601 commented 1 year ago

You didn't give everything I asked for...

I write it a final time and in caps so you hopefully get it: GIVE US THE LATEST.LOG OF YOUR BUNGEECORD PROXY.

BTLP is a plugin, so we needs proxy logs for info. Client logs won't help us here, and proxy logs may contain stuff you think is useless while it isn't.

Like in all honesty, stop acting like you know what we need here.

andreasdc commented 1 year ago

I don't have interest in talking with an disrespectful ignorant. I told you everything, if you want more you can download and test it.

Andre601 commented 1 year ago

I don't have interest in talking with an disrespectful ignorant.

Ironic that this comes from someone refusing to do what is a literal copy-paste job here.

andreasdc commented 1 year ago

That's great, but you literally have everything that you wanted. This is the whole error in the proxy. username disconnected with: NativeIoException : recvAddress(..) failed: Connection reset by peer Happy to help, can't wait for the fix

andrewkm commented 1 year ago

Someone close this dumb report. The kid provides zero actual proxy/plugin logs and is now spamming in unrelated issues #735.

andreasdc commented 1 year ago

Someone close this dumb report. The kid provides zero actual proxy/plugin logs and is now spamming in unrelated issues #735.

Very intelligent creature we have here. Let's find you a reward for this awesome achievement, but let's summarize you. "dumb report" - solid bug that crashes the clients and make the server unplayable for <1.13 versions "The kid" - older than you. "zero actual proxy/plugin logs" - I provided the errors, other than that you don't see anything, only crashes on the client side. " now spamming in unrelated issues" - it is actually the same error, just modified. BTW Any chance for getting this fixed today?

andrewkm commented 1 year ago

Someone close this dumb report. The kid provides zero actual proxy/plugin logs and is now spamming in unrelated issues #735.

Very intelligent creature we have here. Let's find you a reward for this awesome achievement, but let's summarize you. "dumb report" - solid bug that crashes the clients and make the server unplayable for <1.13 versions "The kid" - older than you. "zero actual proxy/plugin logs" - I provided the errors, other than that you don't see anything, only crashes on the client side. " now spamming in unrelated issues" - it is actually the same error, just modified. BTW Any chance for getting this fixed today?

More incoherent rambling that once again provides no proxy logs, and no server side logs.

andreasdc commented 1 year ago

Someone close this dumb report. The kid provides zero actual proxy/plugin logs and is now spamming in unrelated issues #735.

Very intelligent creature we have here. Let's find you a reward for this awesome achievement, but let's summarize you. "dumb report" - solid bug that crashes the clients and make the server unplayable for <1.13 versions "The kid" - older than you. "zero actual proxy/plugin logs" - I provided the errors, other than that you don't see anything, only crashes on the client side. " now spamming in unrelated issues" - it is actually the same error, just modified. BTW Any chance for getting this fixed today?

More incoherent rambling that once again provides no proxy logs, and no server side logs.

No point in discussing with you if you can't even read, greetings.

andrewkm commented 1 year ago

I can assure you, your issue will never be solved without:

Zero effort will always equal zero help, thus this issue will certainly go unnoticed for months to come. If you provided the relevant information we would be willing to help and I'd gladly try to reproduce, but it seems you are not capable of effort in that regard.

I shall take my leave, farewell. :)

andreasdc commented 1 year ago

I can assure you, your issue will never be solved without:

  • Environment information.
  • Server version/build info.
  • Plugin version/build info.
  • Full logs.
  • Full reproduction steps.
  • etc.

Zero effort will always equal zero help, thus this issue will certainly go unnoticed for months to come. If you provided the relevant information we would be willing to help and I'd gladly try to reproduce, but it seems you are not capable of effort in that regard.

I shall take my leave, farewell. :)

Great, till the time you will learn how to read this issue will be fixed, you can go waste your useless energy somewhere else.

Andre601 commented 1 year ago

"dumb report" - solid bug that crashes the clients and make the server unplayable for <1.13 versions

Yet, you haven't provided any real info related to the proxy itself. And so far you only mentioned 1.8 clients, so your <1.13 is probably wrong too.

I've asked you several times to provide the full logs of your BungeeCord proxy, yet you constantly avoid it like the plague, which makes me believe you don't even have access to the proxy in question to proof you have issues there, otherwise why not give the logs as requested? And no, your client-side logs are not any proof of this being a BTLP issue, as any other plugin sending bad packets could be the issue... Or client mods... or the actual backend server itself.

Finally, you constantly say 1.8... And if you actually mean 1.8 and not 1.8.9 or similar, then please use the latest 1.8 version (1.8.9) for your client as there were changes between the versions that make clients incompatible with latest proxy versions.

"The kid" - older than you.

I doubt that you're any older than them. If anything your mental age is that of a kid who doesn't want to do what an actual adult askes them to do. You constantly try to push your views here and when people won't budge you block.

"zero actual proxy/plugin logs" - I provided the errors, other than that you don't see anything, only crashes on the client side.

I constantly asked to give the full logs of your proxy, not just what YOU think is relevant. The full logs provide us with necessary context you lack to give here. You want proper support, then do what you're asked for.

" now spamming in unrelated issues" - it is actually the same error, just modified.

It certainly is not, or else the OP of the issue would've said "This issue still exists, but now different", but they say it's fixed for them, so this is a unrelated issue.

BTW Any chance for getting this fixed today?

No. This is not a product you buy and expect a dedicated team behind to work on. It's an open source project managed and maintained by one guy: CodeCrafter And CodeCrafter doesn't have all the time in the world to work on this project and what little time he has, he uses on more important stuff in his life. So don't expect any fixes soon... Especially if you're giving the equivalent of nothing as info to debug this entire thing.

Also, to now cover your "Just download and test it". You want me to

All for testing this? Meanwhile what I'm asking you to do

Looking at this, I feel like the things you should do would have a lot less work than what I should do what is most likely a bug you caused on your end...

andreasdc commented 1 year ago

The latest bungeecord. The lastest BTLP. Have any tablist. Join with 1.8 and probably any version below 1.13. You get the crash. If you need more, check that by yourself, I assured you more than 3 times. No errors on the proxy, I gave you crash from the client. Probably here and maybe in the other places you need to check the protocol version and send either the string or the BaseComponent. https://github.com/CodeCrafter47/BungeeTabListPlus/blob/9c56d1b048ebff69837bf402025838690b8d5674/bungee/src/main/java/codecrafter47/bungeetablistplus/handler/AbstractLegacyTabOverlayHandler.java#L437C1-L437C1

Here is everything is needed. I'm not going to discuss anything else. If you don't believe that it is different than what I described, you can check by yourself and I will give you my honour.

NEZNAMY commented 1 year ago

At this point the best thing to do would be for Mr. CodeCrafter to go to this user's profile and press "block user". They will no longer be able to comment or open any new issues.

andreasdc commented 1 year ago

You really think there is something more needed in this issue or you are just trolling?

Andre601 commented 1 year ago

You really think there is something more needed in this issue or you are just trolling?

The irony of that comment is beautiful

andreasdc commented 1 year ago

You really think there is something more needed in this issue or you are just trolling?

The irony of that comment is beautiful

Ok, you don't need to answer anything more :D There is second possibility, but I don't want to spam and insult you. You literally have everything that you wanted, everything that is possible, if you think otherwise I don't want to discuss and convince you.

MacTh3Mac commented 1 year ago

Resolved by PR #741 - @andreasdc I would suggest closing this issue and waiting for the PR to be merged from Issue #739 which contains the info required to resolve the bug.

andreasdc commented 1 year ago

Resolved by PR #741 - @andreasdc I would suggest closing this issue and waiting for the PR to be merged from Issue #739 which contains the info required to resolve the bug.

I have this error when building, could you share a jar? Could not determine the dependencies of task ':BungeeTabListPlus:shadowJar'.

Could not resolve all dependencies for configuration ':BungeeTabListPlus:runtimeClasspath'. Could not find de.codecrafter47.taboverlay:taboverlaycommon-config:1.0-SNAPSHOT. Searched in the following locations: