CodeEditApp / CodeEditLanguages

A Collection of Tree-Sitter Parsers for Syntax Highlighting
105 stars 31 forks source link

Add `ERB`/`EJS` Grammar #61

Open cengelbart39 opened 1 year ago

cengelbart39 commented 1 year ago

Description

Adds ERB/EJS grammar via tree-sitter-embedded-template.

Related Issues

Depending on the desire to add more languages to CELanguages, it could close this issue as well.

Checklist

cengelbart39 commented 1 year ago

With the current implementation, there are highlighting issues with ERB and EJS.

For ERB, Ruby doesn't highlight properly (left ERB, right Ruby)

Screenshot_2023-09-24_at_9 42 34_AM

While HTML highlighting works, it isn't perfect either, with some closing tags not being highlighted

Screenshot_2023-09-24_at_9 43 09_AM

It's a similar case for EJS, with JavaScript not highlighting, while HTML highlighting is the same as ERB (left EJS, right JS)

Screenshot_2023-09-24_at_9 43 23_AM

While I have mentioned this in the Discord, I felt I should include it here for anyone waiting on this PR to not be a draft anymore.

cengelbart39 commented 10 months ago

I updated the PR to keep up with changes to the package since created.

Between updates to CE, CEL, CETX, and CESE, the highlighting issue persists.