CodeForAfrica / sensors.AFRICA-api

The sensors.AFRICA API receiving, storing, and processing data received from sensors across the continentent. Accessible at https://api.sensors.africa/
https://api.sensors.africa/
18 stars 7 forks source link

Allows filtering of nodes using location city #102

Closed esirK closed 3 years ago

esirK commented 3 years ago

Description

Allows Filtering of nodes using location city

Fixes # (issue)

Type of change

Screenshots

Screenshot 2021-02-03 at 15 17 53

Screenshot 2021-02-03 at 15 18 03

Data Screenshot 2021-02-03 at 16 33 47

Screenshot 2021-02-03 at 16 33 58

Checklist:

kilemensi commented 3 years ago

QQ @esirK , can we may pull all the nodes and check:

  1. They have cities, and
  2. If we need to do any clean up to make sure names match, etc.
esirK commented 3 years ago

QQ @esirK , can we may pull all the nodes and check:

  1. They have cities, and
  2. If we need to do any clean up to make sure names match, etc.

@kilemensi not all Nodes have cities

kilemensi commented 3 years ago

QQ @esirK , can we may pull all the nodes and check:

  1. They have cities, and
  2. If we need to do any clean up to make sure names match, etc.

@kilemensi not all Nodes have cities

Do they have lat/long that we can use to reverse geocode @esirK ?

esirK commented 3 years ago

QQ @esirK , can we may pull all the nodes and check:

  1. They have cities, and
  2. If we need to do any clean up to make sure names match, etc.

@kilemensi not all Nodes have cities

Do they have lat/long that we can use to reverse geocode @esirK ?

I haven't seen any that's missing lat/long so yes we can do reverse geocode

KhadijaMahanga commented 3 years ago

QQ @esirK , can we may pull all the nodes and check:

  1. They have cities, and
  2. If we need to do any clean up to make sure names match, etc.

@kilemensi not all Nodes have cities

Do they have lat/long that we can use to reverse geocode @esirK ?

I haven't seen any that's missing lat/long so yes we can do reverse geocode

@esirK they are a few with None

esirK commented 3 years ago

QQ @esirK , can we may pull all the nodes and check:

  1. They have cities, and
  2. If we need to do any clean up to make sure names match, etc.

@kilemensi not all Nodes have cities

Do they have lat/long that we can use to reverse geocode @esirK ?

I haven't seen any that's missing lat/long so yes we can do reverse geocode

@esirK they are a few with None

In such a case, I think we will need to manually add the city.

kilemensi commented 3 years ago

@esirK / @KhadijaMahanga how do we even show a node on the map then?

KhadijaMahanga commented 3 years ago

@kilemensi @esirK my bad, I think they all have lat/long...the None locations don't have nodes assigned to them

esirK commented 3 years ago

@kilemensi @KhadijaMahanga I think we can merge this as I work on the reverse geocode.

KhadijaMahanga commented 3 years ago

Shouldn't we be filtering using lat & long instead?

esirK commented 3 years ago

Shouldn't we be filtering using lat & long instead?

I think we want something like v1/node?location__city=Nairobi the same way we are doing for the country