search

CodeNow / api

dat runnable.io api server
https://api.runnable.io
2 stars 1 forks source link

Attach runnable ids on webhooks #2016

Closed podviaznikov closed 7 years ago

podviaznikov commented 7 years ago

Before webhook service would pass just githubid and github username on githubPushInfo and then services downstream would resolve BP ids. I think that is a bit wasteful. Especially because e.x. we already fetch organization in the webhook. I think all downstream services should deal with BP ids, so we need to resolve those as soon as possible.

Found out this problem while working on a bigger PR.

podviaznikov commented 7 years ago

NOTE: Before we did is committer runnable user just in the autofork flow. I don't know why that was the case, I switched it to be checked on any event

podviaznikov commented 7 years ago

Tested webhooks on gamma. AutoForking and AutoDeploy still work