search

CodeNow / api

dat runnable.io api server
https://api.runnable.io
2 stars 1 forks source link

Send the UI better results from multi compose create #2034

Closed Nathan219 closed 7 years ago

Nathan219 commented 7 years ago

The UI has nothing to go on when trying to figure out if all of the clusters are being created. This change sends the random strings back with the response, along with the service names

henrymollman commented 7 years ago

Since API is sending these when the jobs get enqueued we will need to also send the results sorted by hash in the socket message here https://github.com/CodeNow/api/blob/master/lib/workers/cluster.create.js#L61

Nathan219 commented 7 years ago

https://github.com/CodeNow/api/pull/2034#issuecomment-311797209 You've got the clusterName right there, which should be the randomNumber-serverName

henrymollman commented 7 years ago

I'm not sure why we would send these hashes to the front end if we aren't going to send them along with a success/failure socket message

Nathan219 commented 7 years ago

We do send it