search

CodeSleeve / laravel-stapler

Stapler-based file upload package for the Laravel framework.
MIT License
556 stars 109 forks source link

Missing src/Providers dir on local install #61

Closed JungleGenius closed 9 years ago

JungleGenius commented 9 years ago

Hi Travis,

I was looking for a file upload package and found yours. It looks like exactly what I need.

However, I noticed that when I installed the package the vendor/codesleeve/laravel-stapler/src/Providers directory is missing on my end. So you may have fixed the Laravel 5 issues as seen in the following issues:

https://github.com/CodeSleeve/laravel-stapler/issues/60 https://github.com/CodeSleeve/laravel-stapler/issues/56

But I think it still throwing an error because of the missing directory on install from Composer. I'm trying to figure out why that directory is being excluded from the download and install by Composer.

Thanks for all the hard work on this. I want to try and fix this on my own and send you a pull request but as I'm not familiar with Composer package layout it may take me some time. So you may be able to fix this quicker than I can.

Again thanks for sharing your hard work with everyone.

-Daniel

MichaelObi commented 9 years ago

I believe this is the reason I'm getting an ErrorException:

{"error":{"type":"ErrorException","message":"Argument 1 passed to Codesleeve\LaravelStapler\Command s\FastenCommand::__construct() must be an instance of Illuminate\View\Factory, instance of Illumin ate\View\Environment given, called in C:\wamp\www\bhustudapi\vendor\codesleeve\laravel-staple r\src\LaravelStaplerServiceProvider.php on line 91 and defined","file":"C:\wamp\www\bhustudapi\ vendor\codesleeve\laravel-stapler\src\Commands\FastenCommand.php","line":45}}

rbruhn commented 9 years ago

I'm guessing this is not ready for Laravel 5 yet?

geosem42 commented 9 years ago

Not working for me either. When will it be compatible with Laravel 5?

rbruhn commented 9 years ago

@Halnex - I was able to install using 'Codesleeve\LaravelStapler\Providers\L5ServiceProvider' instead of the provider in the readme instructions. He mentions it in another issue here somewhere. Though, I've not actually tested for uploading a project logo in my system. So perhaps it still might break.

tabennett commented 9 years ago

This should be fixed now. The providers directory now contains the service providers (for L4 and L5) that should be used.