search

CodeforNepal / nepalmap_federal

Instance of NepalMap for federal Nepal. Join us!
https://nepalmap.org
MIT License
14 stars 20 forks source link

National Parks generate an error #100

Closed cliftonmcintosh closed 4 years ago

cliftonmcintosh commented 4 years ago

When selecting a geographic area for a national park, NepalMap throws an error. See, for example, https://beta.nepalmap.org/profiles/local-35099-chitawan-national-park/.

That is because the national parks are not present in the population.sql file. They appear to have been removed when the population was updated.

As per issue #38, population data for national parks was set to zero to handle this problem. Pull request #40 added them in, but those data are no longer there.

The data are present in the geography.sql file. See here for local area 35099, the example in the link above. I am not sure why they are not displaying correctly.

nikeshbalami commented 4 years ago

@pratimakandel can you give a quick look at this issues; coming weekend :)

I believe; we have represented national park correctly in both geography.sql and population.sql.

pratimakandel commented 4 years ago

@cliftonmcintosh @nikeshbalami Is this how national parks and reserves should be displayed? chitwan_example

nikeshbalami commented 4 years ago

Yes @pratimakandel

@cliftonmcintosh looks like, we have the similar error at the pre-federal version. The national parks and reserves are throwing display errors: https://nepalmap.org/profiles/vdc-2595-bardiya-national-park/

pratimakandel commented 4 years ago

I have created a pull request for this issue #101. Please let me know if there is anything missing. Thank you.

cliftonmcintosh commented 4 years ago

Fixed by #101

Thank you, @pratimakandel