fix: allow user to exclude global fallback image in feed settings

Soare-Robert-Daniel commented 6 months ago

Summary

The feed setting dashboard did not have a memory to remember if the user did not want a fallback image. Thus, if you have the global fallback set, the dashboard will always use it.

After removing the fallback image from the feed settings and returning later for a short edit, if you do not re-check the fallback image settings and save, the global fallback image will be used; thus, the imported feeds will have the reported problem.

To solve this, I used the value 0 as a marking for no fallback image. When the user presses the Remove button in feed settings, 0 will be used as the image ID. The code already considered 0 as no fallback image, but it was never enabled for the user to use it.

Will affect the visual aspect of the product

NO

Screenshots

https://github.com/Codeinwp/feedzy-rss-feeds/assets/17597852/dcba8f50-880b-4f66-ab0f-e0fd18818fe2

Test instructions

Set a fallback image in General Settings
Create a new feed; you should see the image from the global settings on the fallback image.
Remove the image, then save.
Re-enter the feed settings; you should not see the image from the global settings again.

Check before Pull Request is ready:

[ ] I have written a test and included it in this PR
[x] I have run all tests and they pass
[x] The code passes when running the PHP CodeSniffer
[x] Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
[x] Security and Sanitization requirements have been followed
[x] I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/719

pirate-bot commented 6 months ago

Plugin build for 079628cc6ecfd1db0bed175c93227437fb6192a4 is ready :bellhop_bell:!

Download build

kushh23 commented 6 months ago

Hi @Soare-Robert-Daniel,

I was checking this PR on my site, and it didn't work as expected; I am still facing the same issue mentioned in the initial issue description. Please check this video screencast - https://vertis.d.pr/v/v6mwPb

Here are the test instance details -

Site url - https://feedzy.s3-tastewp.com/wp-admin/
Username- kushnamdev
password - gk(4PnNxsTYLt(BeFzFdTIvz

Soare-Robert-Daniel commented 6 months ago

@kushh23 I was following the steps from your video, and the problem seems to be cached on the WordPress instance. Since you has the current version, when you replaced with the PR version, the cache did not updated since it was still on the same version.

Either, you check with a new instance or try to change the plugin version in the current instance. You can install something like WPIDE and change this number here https://github.com/Codeinwp/feedzy-rss-feeds/blob/eced321ba798d4cd7dca5def0388c96d65ec3201/includes/feedzy-rss-feeds.php#L107, or do it locally and change the content from the ZIP like this: feedzy-rss-feeds 2.zip

You will see if it works when the value 0 is set to the input when you press Remove, like this:

vytisbulkevicius commented 6 months ago

I can't replicate the issue mentioned by @kushh23 and it works as expected to me, so merging this into release.

pirate-bot commented 6 months ago

:tada: This PR is included in version 4.4.9 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Codeinwp / feedzy-rss-feeds