fix: use `WC_Payment_Gateways` instance

Soare-Robert-Daniel commented 6 months ago

Summary

Because we were using new WC_Payment_Gateways, we added duplicate filters in the loop, which resulted in duplicate behavior when rendering the bank details.

By using the singleton pattern provided by the class via WC_Payment_Gateways:instance(), we prevent this bad behavior.

Debugging process

To find where the problem was, I first printed the stack trace on the function that renders the bank details and then checked all Neve functions that were used. There was nothing problematic with them; there were no multiple calls.

This leads me to the idea that some filter was added multiple times, so I printed the stack trace of the WC_Payment_Gateways constructor, which revealed the Neve function that added the filter multiple times.

Will affect the visual aspect of the product

NO

Screenshots

Test instructions

Use WooCommerce
Activate Direct bank transfer in Payments tab of WooCommerce settings
Put some items in the carts and do the checkout.
We should see only an instance of bank details displayed.

Check before Pull Request is ready:

[ ] ~I have written a test and included it in this PR~
[x] I have run all tests and they pass
[x] The code passes when running the PHP CodeSniffer
[x] Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
[x] Security and Sanitization requirements have been followed
[x] I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Closes https://github.com/Codeinwp/neve/issues/4244

pirate-bot commented 6 months ago

Plugin build for c37039c9cbf5d0ea327664f354e82285c6ba797a is ready :bellhop_bell:!

Download build

pirate-bot commented 5 months ago

:tada: This PR is included in version 3.8.8 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Codeinwp / neve