C-137 Browser - Githubissues

CodingGarden / seedling-school-01-frontend-project

For your first project, you will build a frontend website with HTML, CSS and JavaScript. The website will communicate and integrate with a 3rd party Web API.

MIT License

106 stars 14 forks source link

C-137 Browser #26

Open miklosfeczko opened 4 years ago

miklosfeczko commented 4 years ago

Project Name / Title

C-137 Browser

Your Name / Title

Miklos Feczko

Project Description

Get the character or characters based on search terms from Rick and Morty. Pagination between pages and a short information about each character will be listed.

https://github.com/miklosfeczko/C-137-Browser

What 3rd Party Web API do you plan to use?

https://rickandmortyapi.com/documentation/

Which of the following describes you:

[x] YouTube Subscriber
[ ] Twitch Follower
[ ] Patreon Patron
[ ] Superchat Donor
[ ] Streamlabs Donor
[ ] Coding Garden Moderator

miklosfeczko commented 4 years ago

Submitted / Description under review

w3cj commented 4 years ago

Looks good to me! That API is so cool! Feel free to get started.

miklosfeczko commented 4 years ago

The project is deployed and ready.

mahendrjy commented 4 years ago

Live

I love everything about your project

Landing page looks too amazing
I loved the left and right rotated navbar (it's looks amazing). Did you use transform: rotate(90deg) ?
Loading looks amazing when I search or go to next page
You are using pagination, too amazing. I always messed up pagination, it's seems too difficult to do. So I don't do it haha.

I know CSS is personal preference but please fix them haha

Home and Go to app are just too close, seem like it's a single nav and same with Github and About.
Increase the margins between them or

Put all of them in the corners, you can use something like this

.nav-link {
position: absolute;
top: 20px; /* or 40px or what you like or bottom */
left: 20px; /* or 40px or what you like or right */
}

miklosfeczko commented 4 years ago

I used writing-mode: vertical-lr and text-orientation: sideways to rotate the text. I added margins between the nav elements. Thanks for the feedback.

mahendrjy commented 4 years ago

Ohh you used writing-mode. Amazing. I think text-orientation: sideways is default because I'm trying to play with it but nothing happens, I only see a difference when I set it to upright. Your welcome.

w3cj commented 4 years ago

Would you like a ui review / code review?

miklosfeczko commented 4 years ago

I would really appreciate a UI review.