Maturity level two issues

Codit / practical-api-guidelines

Practical guidelines for building & designing APIs with .NET.

MIT License

16 stars 5 forks source link

Maturity level two issues #104

Closed pietersap closed 5 years ago

pietersap commented 5 years ago

This addresses issues

1. 101
1. 100
1. 95
1. 94
1. 90

and also the other smaller remarks (see previous merge) by @fgheysels for which there are no seperate issues.

Note: The commits below also includes commits that were already in the previous merge request. I should have kept the commit tree cleaner.

fgheysels commented 5 years ago

I haven't checked yet, but I 'd prefer to have multiple but smaller PR's (for instance one per issue)

pietersap commented 5 years ago

Agreed. I will do this from now, but there were no issues created at the time and many modifications are very small like removing whitespace etc :)

pietersap commented 5 years ago

I'd suggest to first merge this one, before merging any others smaller merge requests that I add in the future.

MassimoC commented 5 years ago

We already have a first global PR, now I want small PRs with clear title, clear description and link to issue.

pietersap commented 5 years ago

@MassimoC Could we still merge this one as a whole? It addresses a lot of smaller remarks by @fgheysels for which there is no issue. Splitting it up now would make it very messy.

pietersap commented 5 years ago

I referenced the related issues.

MassimoC commented 5 years ago

@MassimoC Could we still merge this one as a whole? It addresses a lot of smaller remarks by @fgheysels for which there is no issue. Splitting it up now would make it very messy.

we won't split up :) We will merge as soon reviewed