search

CogComp / open-eval

An open source evaluation framework for developing NLP systems
8 stars 5 forks source link

User info #178

Closed paultgibbons closed 8 years ago

paultgibbons commented 8 years ago

@joshuacamp I was having issues with finding the redactors remove all methods, so I commented them out in the first commit. Do you know whats going on

Other than that, just addresses the issues that are assigned to me

joshuacamp commented 8 years ago

@paultgibbons Can you give me a more detailed explanation of what errors you're getting when calling the removeAllRelations() method?

Other than that everything looks fine. :+1:

paultgibbons commented 8 years ago

@joshuacamp I cant reproduce it, pushed a commit to undo it. Also made Base View Model abstract and with its own constructor. I think that should be fine for now

joshuacamp commented 8 years ago

@paultgibbons Nice. The removeAllRelations method was added in the last update to the cogcomp libraries so that might've been it. I'll merge when travis passes.