search

CogentRedTester / mpv-sub-select

An advanced conditional subtitle track selector for mpv player
MIT License
89 stars 8 forks source link

Add secondary-sid support #26

Open vhagedorn opened 11 months ago

vhagedorn commented 11 months ago

Add support for secondary-sid option in mpv via dlang field. Field is functionally identical to slang field except that it is optional.

CogentRedTester commented 10 months ago

Sorry for the delayed response, I was on holiday. If I have not reviewed this PR in a weeks time please ping this thread to remind me.

zhongfly commented 6 months ago

Sorry for the delayed response, I was on holiday. If I have not reviewed this PR in a weeks time please ping this thread to remind me.

ping

CogentRedTester commented 6 months ago

I have a number of problems with the current form of this PR, but before I go in to them there is a specific question that needs to be answered: how does the secondary subtitle selection and the normal subtitle selection influence each other.

The normal subtitle selection code is based on the currently selected audio. If you have audio-mode enabled, then the selection of both audio and subtitles depend on each other; a pair of audio and subtitle tracks must pass a match for them both to be selected.

How does the secondary subtitle option fit into this? Is it completely independent from the normal subtitles where it gets selected separately? Should the primary subtitles be selected first and the secondary subtitles on be selected afterwards based on that selection? Would both the primary and secondary subtitles need to match to pass a specific preference? This question needs to be answered and justified before this PR can be properly reviewed.