Coldcard / ckbunker

CKBunker - A Bitcoin HSM solution to securely authorize transactions using an online Coldcard (over Tor)
http://ckbunker.com
Other
49 stars 23 forks source link

latest jinja2 brakes the HSM config interpretation #21

Open polto opened 2 years ago

polto commented 2 years ago

Seems jinja2 has change a bit and ckbunker need some adaptation.

I am having this error with jinja2 version 3.1.2:

AttributeError: module 'jinja2' has no attribute 'escape'

Reading https://jinja.palletsprojects.com/en/3.1.x/changes/ I see

Markup and escape should be imported from MarkupSafe.

I downgraded to 3.0.3 and now everything works well.

pip uninstall jinja2 pip install jinja2==3.0.3

scgbckbone commented 2 years ago

hi @polto, thanks for pointing this out. Seems like this commit already fixed the issue and you do not need to rely on older jinja2 library. Make sure to update/pull changes from remote.

scgbckbone commented 2 years ago

thanks for this @polto - opened PR https://github.com/Coldcard/ckbunker/pull/22

scgbckbone commented 2 years ago

https://github.com/Coldcard/ckbunker/pull/22 merged