search

Colfenor / classic-mceliece-rust

This is a pure-rust safe-rust implementation of the Classic McEliece post-quantum scheme
MIT License
24 stars 11 forks source link

Release not HUGE release of v2.x #43

Closed faern closed 1 year ago

faern commented 1 year ago

Hi again. Follow up to #41...

A bunch of people might need or want to still support round3 CME in various programs for quite a while (us included). But the download from crates.io is pretty large, as discovered in the other issue. Would you please consider backporting #42 (probably branch from 68fdbe6 and cherry-pick it in?) and release 2.0.2 with the only difference being that it's smaller?

Thanks for your work on maintaining this crate, and thanks for the 3.0 release! :partying_face:

Colfenor commented 1 year ago

Heyo,

sure thing, if it's possible to reduce dependency file size for users on a previous release by a hotfix, let's do this One thing which I worry about is the following:

so currently I created the hotfix branch, from the v2.0.1 commit and cherry picked the exclude testdata commit plus updated cargo toml version & changelog and added a git tag v2.0.2

If we release this on crates.io, I'm assuming this branch should never be deleted in order to preserve history, so therefore I should add a lock/branch-protection I recon :thinking:

Thanks for your work on maintaining this crate, and thanks for the 3.0 release! :partying_face:

No problem, gladly :) I'm happy that people find this crate useful

faern commented 1 year ago

Just keep the tag. No branch needed. The git tag will preserve the history

Colfenor commented 1 year ago

Alright, the fix concerning crate size v2.0.2 should be published now, please verify and close this issue, if everything went fine upgrading :)

faern commented 1 year ago

Looks good. Thanks for this!

Nitpick/FYI: You might want to look into git rebasing (squashing especially) ;). So you don't need three commits to change the changelog. Or in this case where you just want to make more changes to the latest commit you can just throw on --amend to git commit in order to tack on further changes to the latest commit :) With interactive rebasing (git rebase -i {branch}) it's even more powerful. Allows you to squash together multiple commits in order to reduce the noise in the history.