ColinPitrat / caprice32

An emulator of the Amstrad CPC 8bit home computer range.
GNU General Public License v2.0
148 stars 32 forks source link

Windows 64 bit release missing file libbrotlidec.dll so program will not run. #173

Closed riwide closed 4 years ago

ColinPitrat commented 4 years ago

This is now fixed.

ColinPitrat commented 4 years ago

Ideally we would need a test for this. I suppose the end-to-end test doesn't catch it because it finds the DLL locally.

riwide commented 4 years ago

thanks

On Mon, 13 Jul 2020 at 14:58, Colin Pitrat notifications@github.com wrote:

This is now fixed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ColinPitrat/caprice32/issues/173#issuecomment-657577276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHFCH2XP4Y2QUJVMEKJ6VA3R3MHHBANCNFSM4OXHATTA .

ColinPitrat commented 4 years ago

Note: I temporarily reverted the fix to try to write a test that detects the issue. It turns out quite hard because the DLL are found on the system ...

ColinPitrat commented 4 years ago

I opened issue #174 to track writing a test for this.