CollActionteam / collaction_app

CollAction cross-platform mobile application for iOS and Android
https://collaction.org
GNU General Public License v3.0
33 stars 12 forks source link

core(route): Migrate to go_router. #290

Closed wizlif closed 1 year ago

wizlif commented 2 years ago

Complete migration from auto_route to go_router. Much shorter build runs (Only freezed 😄 )

Will still need some extensive testing

Closes #285

codecov[bot] commented 2 years ago

Codecov Report

Merging #290 (2015014) into development (8745836) will decrease coverage by 0.36%. The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           development    #290      +/-   ##
==============================================
- Coverage        10.17%   9.81%   -0.37%     
==============================================
  Files              136     138       +2     
  Lines             3657    3781     +124     
==============================================
- Hits               372     371       -1     
- Misses            3285    3410     +125     
Impacted Files Coverage Δ
lib/infrastructure/core/settings_repository.dart 0.00% <0.00%> (ø)
lib/presentation/auth/auth_screen.dart 1.81% <0.00%> (ø)
lib/presentation/auth/widgets/profile_photo.dart 0.00% <0.00%> (ø)
lib/presentation/auth/widgets/verified.dart 3.03% <0.00%> (+0.17%) :arrow_up:
...presentation/contact_form/contact_form_screen.dart 6.25% <0.00%> (-0.42%) :arrow_down:
lib/presentation/core/app_widget.dart 0.00% <0.00%> (ø)
lib/presentation/core/routes/app_page.ext.dart 0.00% <0.00%> (ø)
lib/presentation/core/routes/router.dart 0.00% <0.00%> (ø)
...rowdaction_details/crowdaction_details_screen.dart 0.00% <0.00%> (ø)
.../crowdaction_details/widgets/commitment_badge.dart 0.00% <0.00%> (ø)
... and 22 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

wizlif commented 2 years ago

There is still a trending issue on go_router shell route about maintaining page state. I will not merge till there is a fix for it. The P.R is still in review and hopefully won't take long.

https://github.com/flutter/flutter/issues/99124 https://github.com/flutter/packages/pull/2650

Xazin commented 2 years ago

There is still a trending issue on go_router shell route about maintaining page state. I will not merge till there is a fix for it. The P.R is still in review and hopefully won't take long.

flutter/flutter#99124 flutter/packages#2650

Alright sounds good, let's try to rebase this branch once in a while or similar, to make the merge easier later.

Xazin commented 1 year ago

@wizlif Version 7.1.0 of Go Router resolves the issues we have been waiting for :tada:

wizlif commented 1 year ago

Let me do a fresh version of this, feels like a rebase will be crazy