CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.88k stars 710 forks source link

Rename "Close" button to "OK" in the "Show Sheets" dialog #10174

Open Darshan-upadhyay1110 opened 1 month ago

Darshan-upadhyay1110 commented 1 month ago

Description:

Steps to reproduce:

  1. Open the ods file.
  2. Create more then 1 sheet
  3. Right-click on Sheet 1 to reveal the sheet menu items.
  4. Select Hide Sheet from the menu.
  5. Right-click on Sheet 2 to reveal the sheet menu items.
  6. Select Show Sheets from the menu.

Change Button Label to "OK" and Add Heading/Label for Sheets Selection

Current Behavior:

Requested Changes:

  1. Button Label: Change the blue primary button's text to "OK".

    • While a more specific label like "Show sheets" would be ideal, it may become too long in languages such as Portuguese or German.
  2. Disabled Button: Ensure the OK button is disabled until at least one checkbox is selected.

  3. Add Heading/Label: Add a text line (not necessarily a header bar) before the checkboxes, saying "Show one or more sheets". This will provide clear context for the user.

Action Items:

image

image

ruchit2005 commented 1 month ago

I would like to fix it

Darshan-upadhyay1110 commented 1 month ago

Hello @ruchit2005 sure.

Darshan-upadhyay1110 commented 1 month ago

@ruchit2005, just wanted to inform you about some minor updates or requirements for this task, but I’m sure you’ll handle them with ease! If you need any help or pointers, feel free to reach out—we can always discuss. You can also ask in our Matrix community for support, which is super helpful: https://app.element.io/#/room/#cool-dev:matrix.org.

ruchit2005 commented 1 month ago

Hi, Could you help me and direct me to the files where the changes are to be made

Darshan-upadhyay1110 commented 1 month ago

Hi, Could you help me and direct me to the files where the changes are to be made

Hey @ruchit2005 ! 😄

The fun part is finding those code points yourself using debugging, right? 🕵️‍♂️ If I gave away all the files, there wouldn’t be much learning left in solving this GH issue! 😉

Enjoy the hunt! 🚀

And if still there are difficulties to start the please feel free to ping here :wink:

Darshan-upadhyay1110 commented 1 month ago

Hello @ruchit2005 any joy here ? Did you get any starting point ?

Mark-a-obrien commented 1 month ago

Hello, could you assign this to me please.

Darshan-upadhyay1110 commented 1 month ago

Hello, could you assign this to me please.

Sure, Happy hacking @Mark-a-obrien :)

Mark-a-obrien commented 1 month ago

Hi @Darshan-upadhyay1110,

I'm having a bit of getting setup with gitpod following the guide at https://collaboraonline.github.io/post/build-code/#build-code-on-gitpod.

Any advise would be apricated.

The left terminal is showing the following:

 HISTFILE=/workspace/.gitpod/cmd-1 history -r; {
gp sync-await configuring
} && {
make -j$(nproc) run
}
info[gp-vncsession]: Increased shmem to 4GB
info[gp-vncsession]: * Starting system message bus dbus ...done.
info[gp-vncsession]: Starting tigerVNC server on port 5900
info[gp-vncsession]: Waiting for the desktop to be fully loaded ...
info[gp-vncsession]: Starting noVNC web client on port 6080
gitpod /workspace/online (master) $  HISTFILE=/workspace/.gitpod/cmd-1 history -r; {
> gp sync-await configuring
> } && {
> make -j$(nproc) run
> }
configuring done
mkdir -p /workspace/online/jails
make  all-recursive
make[1]: Entering directory '/workspace/online'
Making all in .
make[2]: Entering directory '/workspace/online'
  CXX      kit/ChildSession.o
  CXX      kit/ForKit.o
  CXX      kit/Kit.o
  CXX      kit/KitWebSocket.o
  CXX      common/FileUtil.o
  CXX      common/JailUtil.o
  CXX      common/Log.o
  CXX      common/Protocol.o
  CXX      common/StringVector.o
  CXX      common/Session.o
  CXX      common/Seccomp.o
  CXX      common/MobileApp.o
  CXX      common/TraceEvent.o
  CXX      common/SigUtil.o
  CXX      common/SpookyV2.o
  CXX      common/Unit.o
  CXX      common/Uri.o
In file included from common/SigUtil.cpp:46:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from common/SigUtil.cpp:46:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/SigUtil.cpp:46:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/Unit.hpp:21,
                 from common/Unit.cpp:10:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from common/Unit.hpp:21,
                 from common/Unit.cpp:10:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from common/Unit.hpp:21,
                 from common/Unit.cpp:10:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from ./net/WebSocketHandler.hpp:15,
                 from common/Session.hpp:29,
                 from common/Session.cpp:14:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from ./net/WebSocketHandler.hpp:15,
                 from common/Session.hpp:29,
                 from common/Session.cpp:14:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
npm WARN old lockfile 
npm WARN old lockfile The npm-shrinkwrap.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile 
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile 
  CXX      common/Util.o
In file included from ./net/WebSocketHandler.hpp:15,
                 from common/Session.hpp:29,
                 from common/Session.cpp:14:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
make[2]: *** [Makefile:3466: common/SigUtil.o] Error 1@babel/helper-
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:3466: common/FileUtil.o] Error 1babel/helpers
make[2]: *** [Makefile:3466: common/Unit.o] Error 1es/argparse: sill
make[2]: *** [Makefile:3466: common/Session.o] Error 1assert: sill i
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'shrinkpack@1.0.0-alpha',
npm WARN EBADENGINE   required: { node: '>=4.0', npm: '<=5.8.0' },
npm WARN EBADENGINE   current: { node: 'v16.18.1', npm: '8.19.2' }
npm WARN EBADENGINE }
npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm WARN deprecated w3c-hr-time@1.0.2: Use your platform's native performance.now() and performance.timeOrigin.
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated socks@1.1.10: If using 2.x branch, please upgrade to at least 2.1.6 to avoid a serious bug with socket data flow and an import issue introduced in 2.1.0
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated osenv@0.1.5: This package is no longer supported.
npm WARN deprecated npmlog@5.0.1: This package is no longer supported.
npm WARN deprecated move-concurrently@1.0.1: This package is no longer supported.
npm WARN deprecated lock-verify@2.2.2: This package is no longer supported.
npm WARN deprecated node-fetch-npm@2.0.4: This module is not used anymore, npm uses minipass-fetch for its fetch implementation now
npm WARN deprecated find-npm-prefix@1.0.2: This package is no longer supported.
npm WARN deprecated figgy-pudding@3.5.2: This module is no longer supported.
npm WARN deprecated fs-write-stream-atomic@1.0.10: This package is no longer supported.
npm WARN deprecated domexception@2.0.1: Use your platform's native DOMException instead
npm WARN deprecated gauge@3.0.2: This package is no longer supported.
npm WARN deprecated copy-concurrently@1.0.5: This package is no longer supported.
npm WARN deprecated are-we-there-yet@2.0.0: This package is no longer supported.
npm WARN deprecated abab@2.0.6: Use your platform's native atob() and btoa() methods instead
npm WARN deprecated @stylelint/postcss-markdown@0.36.2: Use the original unforked package instead: postcss-markdown
npm WARN deprecated @stylelint/postcss-css-in-js@0.37.3: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated npmlog@4.1.2: This package is no longer supported.
npm WARN deprecated are-we-there-yet@1.1.7: This package is no longer supported.
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated debug@4.2.0: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated glob@7.1.6: Glob versions prior to v9 are no longer supported
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated rimraf@2.6.3: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated gauge@2.7.4: This package is no longer supported.
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated eslint@7.0.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 907 packages, and audited 908 packages in 25s

116 packages are looking for funding
  run `npm fund` for details

37 vulnerabilities (2 low, 11 moderate, 23 high, 1 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
npm notice 
npm notice New major version of npm available! 8.19.2 -> 10.9.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.9.0
npm notice Run npm install -g npm@10.9.0 to update!
npm notice 
make[2]: Leaving directory '/workspace/online'
make[1]: *** [Makefile:7489: all-recursive] Error 1
make[1]: Leaving directory '/workspace/online'
make: *** [Makefile:2075: all] Error 2
gitpod /workspace/online (master) $ ^C
gitpod /workspace/online (master) $ 
Darshan-upadhyay1110 commented 1 month ago

Hi @Darshan-upadhyay1110,

I'm having a bit of getting setup with gitpod following the guide at https://collaboraonline.github.io/post/build-code/#build-code-on-gitpod.

Any advise would be apricated.

The left terminal is showing the following:

 HISTFILE=/workspace/.gitpod/cmd-1 history -r; {
gp sync-await configuring
} && {
make -j$(nproc) run
}
info[gp-vncsession]: Increased shmem to 4GB
info[gp-vncsession]: * Starting system message bus dbus ...done.
info[gp-vncsession]: Starting tigerVNC server on port 5900
info[gp-vncsession]: Waiting for the desktop to be fully loaded ...
info[gp-vncsession]: Starting noVNC web client on port 6080
gitpod /workspace/online (master) $  HISTFILE=/workspace/.gitpod/cmd-1 history -r; {
> gp sync-await configuring
> } && {
> make -j$(nproc) run
> }
configuring done
mkdir -p /workspace/online/jails
make  all-recursive
make[1]: Entering directory '/workspace/online'
Making all in .
make[2]: Entering directory '/workspace/online'
  CXX      kit/ChildSession.o
  CXX      kit/ForKit.o
  CXX      kit/Kit.o
  CXX      kit/KitWebSocket.o
  CXX      common/FileUtil.o
  CXX      common/JailUtil.o
  CXX      common/Log.o
  CXX      common/Protocol.o
  CXX      common/StringVector.o
  CXX      common/Session.o
  CXX      common/Seccomp.o
  CXX      common/MobileApp.o
  CXX      common/TraceEvent.o
  CXX      common/SigUtil.o
  CXX      common/SpookyV2.o
  CXX      common/Unit.o
  CXX      common/Uri.o
In file included from common/SigUtil.cpp:46:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from common/SigUtil.cpp:46:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/SigUtil.cpp:46:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/Unit.hpp:21,
                 from common/Unit.cpp:10:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from common/Unit.hpp:21,
                 from common/Unit.cpp:10:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from common/Unit.hpp:21,
                 from common/Unit.cpp:10:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from ./net/WebSocketHandler.hpp:15,
                 from common/Session.hpp:29,
                 from common/Session.cpp:14:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from ./net/WebSocketHandler.hpp:15,
                 from common/Session.hpp:29,
                 from common/Session.cpp:14:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
npm WARN old lockfile 
npm WARN old lockfile The npm-shrinkwrap.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile 
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile 
  CXX      common/Util.o
In file included from ./net/WebSocketHandler.hpp:15,
                 from common/Session.hpp:29,
                 from common/Session.cpp:14:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
make[2]: *** [Makefile:3466: common/SigUtil.o] Error 1@babel/helper-
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:3466: common/FileUtil.o] Error 1babel/helpers
make[2]: *** [Makefile:3466: common/Unit.o] Error 1es/argparse: sill
make[2]: *** [Makefile:3466: common/Session.o] Error 1assert: sill i
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'shrinkpack@1.0.0-alpha',
npm WARN EBADENGINE   required: { node: '>=4.0', npm: '<=5.8.0' },
npm WARN EBADENGINE   current: { node: 'v16.18.1', npm: '8.19.2' }
npm WARN EBADENGINE }
npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm WARN deprecated w3c-hr-time@1.0.2: Use your platform's native performance.now() and performance.timeOrigin.
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated socks@1.1.10: If using 2.x branch, please upgrade to at least 2.1.6 to avoid a serious bug with socket data flow and an import issue introduced in 2.1.0
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated osenv@0.1.5: This package is no longer supported.
npm WARN deprecated npmlog@5.0.1: This package is no longer supported.
npm WARN deprecated move-concurrently@1.0.1: This package is no longer supported.
npm WARN deprecated lock-verify@2.2.2: This package is no longer supported.
npm WARN deprecated node-fetch-npm@2.0.4: This module is not used anymore, npm uses minipass-fetch for its fetch implementation now
npm WARN deprecated find-npm-prefix@1.0.2: This package is no longer supported.
npm WARN deprecated figgy-pudding@3.5.2: This module is no longer supported.
npm WARN deprecated fs-write-stream-atomic@1.0.10: This package is no longer supported.
npm WARN deprecated domexception@2.0.1: Use your platform's native DOMException instead
npm WARN deprecated gauge@3.0.2: This package is no longer supported.
npm WARN deprecated copy-concurrently@1.0.5: This package is no longer supported.
npm WARN deprecated are-we-there-yet@2.0.0: This package is no longer supported.
npm WARN deprecated abab@2.0.6: Use your platform's native atob() and btoa() methods instead
npm WARN deprecated @stylelint/postcss-markdown@0.36.2: Use the original unforked package instead: postcss-markdown
npm WARN deprecated @stylelint/postcss-css-in-js@0.37.3: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated npmlog@4.1.2: This package is no longer supported.
npm WARN deprecated are-we-there-yet@1.1.7: This package is no longer supported.
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated debug@4.2.0: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated glob@7.1.6: Glob versions prior to v9 are no longer supported
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated rimraf@2.6.3: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated gauge@2.7.4: This package is no longer supported.
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated eslint@7.0.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 907 packages, and audited 908 packages in 25s

116 packages are looking for funding
  run `npm fund` for details

37 vulnerabilities (2 low, 11 moderate, 23 high, 1 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
npm notice 
npm notice New major version of npm available! 8.19.2 -> 10.9.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.9.0
npm notice Run npm install -g npm@10.9.0 to update!
npm notice 
make[2]: Leaving directory '/workspace/online'
make[1]: *** [Makefile:7489: all-recursive] Error 1
make[1]: Leaving directory '/workspace/online'
make: *** [Makefile:2075: all] Error 2
gitpod /workspace/online (master) $ ^C
gitpod /workspace/online (master) $ 

@Mark-a-obrien can you please try make clean and the make run -j16 in that left terminal.

Darshan-upadhyay1110 commented 1 month ago

Hello @Mark-a-obrien we are fixing the issue , please can you try Gitpod after this PR gets merged ?

https://github.com/CollaboraOnline/online/pull/10320

Thanks for the error message, it helped us a lot

Cheers, Darshan

Mark-a-obrien commented 1 month ago

Hi @Darshan-upadhyay1110,

Thanks for the reply.

I'll try again after #10320 is merged. Thanks

Just to let you know I got the below when I tried running make clean and the make run -j16 in that left terminal.

 HISTFILE=/workspace/.gitpod/cmd-1 history -r; {
make -j$(nproc) run
}
info[gp-vncsession]: * system message bus already started; not starting.
info[gp-vncsession]: Starting tigerVNC server on port 5900
gitpod /workspace/online (master) $  HISTFILE=/workspace/.gitpod/cmd-1 history -r; {
> make -j$(nproc) run
> }
make  all-recursive
make[1]: Entering directory '/workspace/online'
Making all in .
make[2]: Entering directory '/workspace/online'
  CXX      common/FileUtil.o
  CXX      common/Session.o
  CXX      common/SigUtil.o
  CXX      common/Unit.o
  CXX      common/Util-desktop.o
  CXX      common/ConfigUtil.o
  CXX      common/Authorization.o
  CXX      common/CommandControl.o
  CXX      common/CoolMount.o
  CXX      common/Simd.o
  CXX      kit/KitQueue.o
  CXX      net/DelaySocket.o
  CXX      net/HttpRequest.o
  CXX      net/HttpHelper.o
  CXX      net/NetUtil.o
  CXX      net/Socket.o
  CXX      wsd/Exceptions.o
  CXX      net/Ssl.o
  CXX      kit/forkit-main.o
In file included from ./net/DelaySocket.hpp:14,
                 from net/DelaySocket.cpp:14:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from ./net/DelaySocket.hpp:14,
                 from net/DelaySocket.cpp:14:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/SigUtil.cpp:46:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from common/SigUtil.cpp:46:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/Unit.hpp:21,
                 from common/Unit.cpp:10:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 | nt getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                              ^~~~~~~

In file included from common/Unit.hpp:21,
                 from common/Unit.cpp:10:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from ./net/HttpRequest.hpp:32,
                 from net/HttpHelper.hpp:15,
                 from net/HttpHelper.cpp:14:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from ./net/HttpRequest.hpp:32,
                 from net/HttpHelper.hpp:15,
                 from net/HttpHelper.cpp:14:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from net/HttpRequest.hpp:32,
                 from net/HttpRequest.cpp:14:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from net/HttpRequest.hpp:32,
                 from net/HttpRequest.cpp:14:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from net/Socket.cpp:14:
net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from net/Socket.cpp:14:
net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/Unit.hpp:21,
                 from common/Unit.cpp:10:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from ./net/HttpRequest.hpp:32,
                 from net/HttpHelper.hpp:15,
                 from net/HttpHelper.cpp:14:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX�� is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from common/SigUtil.cpp:46:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from ./net/DelaySocket.hpp:14,
                 from net/DelaySocket.cpp:14:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from net/NetUtil.cpp:18:
net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from net/NetUtil.cpp:18:
net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from net/HttpRequest.hpp:32,
                 from net/HttpRequest.cpp:14:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from net/Socket.cpp:14:
net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from net/NetUtil.cpp:18:
net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from ./net/WebSocketHandler.hpp:15,
                 from common/Session.hpp:29,
                 from common/Session.cpp:14:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from ./net/WebSocketHandler.hpp:15,
                 from common/Session.hpp:29,
                 from common/Session.cpp:14:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from ./net/WebSocketHandler.hpp:15,
                 from common/Session.hpp:29,
                 from common/Session.cpp:14:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
make[2]: *** [Makefile:3466: common/SigUtil.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
make[2]: *** [Makefile:3466: net/DelaySocket.o] Error 1
make[2]: *** [Makefile:3466: net/HttpHelper.o] Error 1
make[2]: *** [Makefile:3466: common/FileUtil.o] Error 1
make[2]: *** [Makefile:3466: net/HttpRequest.o] Error 1
make[2]: *** [Makefile:3466: net/NetUtil.o] Error 1
make[2]: *** [Makefile:3466: common/Unit.o] Error 1
make[2]: *** [Makefile:3466: common/Session.o] Error 1
make[2]: *** [Makefile:3466: net/Socket.o] Error 1
make[2]: Leaving directory '/workspace/online'
make[1]: *** [Makefile:7489: all-recursive] Error 1
make[1]: Leaving directory '/workspace/online'
make: *** [Makefile:2075: all] Error 2
gitpod /workspace/online (master) $ make clean
Making clean in .
make[1]: Entering directory '/workspace/online'
if test -s ./coolwsd; then echo "Cleaning up..." && ./coolwsd --disable-cool-user-checking --cleanup --o:logging.level=trace || rm -f ./coolwsd; fi
 rm -f coolforkit-caps coolforkit-ns coolmount coolstress coolconvert coolconfig coolwsd coolwsd-inproc
rm -rf .libs _libs
if test -s ./coolwsd; then echo "Cleaning up..." && ./coolwsd --disable-cool-user-checking --cleanup --o:logging.level=trace || rm -f ./coolwsd; fi
if test "z/workspace/online/systemplate" != "z"; then rm -rf "/workspace/online/systemplate" || echo "WARNING: failed to remove the systemplate"; fi
if test "z/workspace/online/jails" != "z"; then rm -rf "/workspace/online/jails" || echo "WARNING: failed to remove all jails cleanly"; fi
rm -rf "./loleaflet"
rm -rf loolconfig loolconvert loolforkit loolmap loolmount # kill old binaries
rm -rf loolwsd loolwsd_fuzzer coolwsd_fuzzer loolstress loolsocketdump
rm -rf /workspace/online/gcov; find . -iname "*.gc??" -delete
 rm -f clientnb connect lokitclient coolmap coolbench coolsocketdump
rm -f *.o
rm -f common/*.o
rm -f fuzzer/*.o
rm -f kit/*.o
rm -f net/*.o
rm -f tools/*.o
rm -f wsd/*.o
rm -f wsd/wopi/*.o
rm -f *.lo
make[1]: Leaving directory '/workspace/online'
Making clean in browser
make[1]: Entering directory '/workspace/online/browser'
Making clean in .
make[2]: Entering directory '/workspace/online/browser'
test -z "tscompile.done /workspace/online/browser/debug/cool-src.js ./dist/bundle.css ./dist/bundle.js /workspace/online/browser/debug/cool-src.js" || rm -f tscompile.done /workspace/online/browser/debug/cool-src.js ./dist/bundle.css ./dist/bundle.js /workspace/online/browser/debug/cool-src.js
rm -rf .libs _libs
rm -f *.lo
make[2]: Leaving directory '/workspace/online/browser'
Making clean in l10n
make[2]: Entering directory '/workspace/online/browser/l10n'
rm -rf .libs _libs
rm -f *.lo
make[2]: Leaving directory '/workspace/online/browser/l10n'
make[1]: Leaving directory '/workspace/online/browser'
Making clean in test
make[1]: Entering directory '/workspace/online/test'
 rm -f fakesockettest
rm -rf .libs _libs
rm -rf ../kit/.libs ../kit/_libs
rm -rf ../wsd/.libs ../wsd/_libs
test -z "unit-perf.la unit-proxy.la unit-synthetic-lok.la unit-wopi-async-slow.la unit-tiletest.la unit-wopi-fail-upload.la unit-each-view.la unit-wopi-stuck-save.la unit-load.la unit-integration.la unit-httpws.la unit-quarantine.la unit-load-torture.la unit-save-torture.la unit-copy-paste.la unit-copy-paste-writer.la unit-crash.la unit-wopi-fileurl.la unit-wopi-save-on-exit.la unit-wopi-documentconflict.la unit-close.la unit-wopi-languages.la unit-insert-delete.la unit-password-protected.la unit-uno-command.la unit-wopi-httpredirect.la unit-wopi-watermark.la unit-wopi-lock.la unit-calc.la unit-http.la unit-wopi-temp.la unit-session.la unit-render-shape.la unit-wopi-ownertermination.la unit-wopi-httpheaders.la unit-wopi.la unit-wopi-crash-modified.la unit-oauth.la unit-wopi-versionrestore.la unit-convert.la unit-rendering-options.la unit-paste.la unit-large-paste.la unit-typing.la unit-cursor.la unit-render-search-result.la unit-tiff-load.la unit-wopi-saveas-with-encoded-file-name.la unit-storage.la unit-wopi-async-upload-modifyclose.la unit-wopi-saveas.la unit_wopi_renamefile.la unit-wopi-loadencoded.la unit-prefork.la unit-bad-doc-load.la unit-hosting.la unit-join-disconnect.la unit-initial-load-fail.la unit-timeout.la unit-timeout_socket.la unit-timeout_wsping.la unit-timeout_conn.la unit-timeout_none.la unit-base.la " || rm -f unit-perf.la unit-proxy.la unit-synthetic-lok.la unit-wopi-async-slow.la unit-tiletest.la unit-wopi-fail-upload.la unit-each-view.la unit-wopi-stuck-save.la unit-load.la unit-integration.la unit-httpws.la unit-quarantine.la unit-load-torture.la unit-save-torture.la unit-copy-paste.la unit-copy-paste-writer.la unit-crash.la unit-wopi-fileurl.la unit-wopi-save-on-exit.la unit-wopi-documentconflict.la unit-close.la unit-wopi-languages.la unit-insert-delete.la unit-password-protected.la unit-uno-command.la unit-wopi-httpredirect.la unit-wopi-watermark.la unit-wopi-lock.la unit-calc.la unit-http.la unit-wopi-temp.la unit-session.la unit-render-shape.la unit-wopi-ownertermination.la unit-wopi-httpheaders.la unit-wopi.la unit-wopi-crash-modified.la unit-oauth.la unit-wopi-versionrestore.la unit-convert.la unit-rendering-options.la unit-paste.la unit-large-paste.la unit-typing.la unit-cursor.la unit-render-search-result.la unit-tiff-load.la unit-wopi-saveas-with-encoded-file-name.la unit-storage.la unit-wopi-async-upload-modifyclose.la unit-wopi-saveas.la unit_wopi_renamefile.la unit-wopi-loadencoded.la unit-prefork.la unit-bad-doc-load.la unit-hosting.la unit-join-disconnect.la unit-initial-load-fail.la unit-timeout.la unit-timeout_socket.la unit-timeout_wsping.la unit-timeout_conn.la unit-timeout_none.la unit-base.la 
rm -f ./so_locations
 rm -f fakesockettest unittest unithttplib
rm -f *.o
rm -f ../common/*.o
rm -f ../kit/*.o
rm -f ../kit/*.lo
rm -f ../net/*.o
rm -f ../wsd/*.o
rm -f ../wsd/*.lo
test -z "unit-perf.log unit-proxy.log unit-synthetic-lok.log unit-wopi-async-slow.log unit-tiletest.log unit-wopi-fail-upload.log unit-each-view.log unit-wopi-stuck-save.log unit-load.log unit-integration.log unit-httpws.log unit-quarantine.log unit-load-torture.log unit-save-torture.log unit-copy-paste.log unit-copy-paste-writer.log unit-crash.log unit-wopi-fileurl.log unit-wopi-save-on-exit.log unit-wopi-documentconflict.log unit-close.log unit-wopi-languages.log unit-insert-delete.log unit-password-protected.log unit-uno-command.log unit-wopi-httpredirect.log unit-wopi-watermark.log unit-wopi-lock.log unit-calc.log unit-http.log unit-wopi-temp.log unit-session.log unit-render-shape.log unit-wopi-ownertermination.log unit-wopi-httpheaders.log unit-wopi.log unit-wopi-crash-modified.log unit-oauth.log unit-wopi-versionrestore.log unit-convert.log unit-rendering-options.log unit-paste.log unit-large-paste.log unit-typing.log unit-cursor.log unit-render-search-result.log unit-tiff-load.log unit-wopi-saveas-with-encoded-file-name.log unit-storage.log unit-wopi-async-upload-modifyclose.log unit-wopi-saveas.log unit_wopi_renamefile.log unit-wopi-loadencoded.log unit-prefork.log unit-bad-doc-load.log unit-hosting.log unit-join-disconnect.log unit-initial-load-fail.log unit-timeout.log unit-timeout_socket.log unit-timeout_wsping.log unit-timeout_conn.log unit-timeout_none.log unit-base.log unithttplib.log" || rm -f unit-perf.log unit-proxy.log unit-synthetic-lok.log unit-wopi-async-slow.log unit-tiletest.log unit-wopi-fail-upload.log unit-each-view.log unit-wopi-stuck-save.log unit-load.log unit-integration.log unit-httpws.log unit-quarantine.log unit-load-torture.log unit-save-torture.log unit-copy-paste.log unit-copy-paste-writer.log unit-crash.log unit-wopi-fileurl.log unit-wopi-save-on-exit.log unit-wopi-documentconflict.log unit-close.log unit-wopi-languages.log unit-insert-delete.log unit-password-protected.log unit-uno-command.log unit-wopi-httpredirect.log unit-wopi-watermark.log unit-wopi-lock.log unit-calc.log unit-http.log unit-wopi-temp.log unit-session.log unit-render-shape.log unit-wopi-ownertermination.log unit-wopi-httpheaders.log unit-wopi.log unit-wopi-crash-modified.log unit-oauth.log unit-wopi-versionrestore.log unit-convert.log unit-rendering-options.log unit-paste.log unit-large-paste.log unit-typing.log unit-cursor.log unit-render-search-result.log unit-tiff-load.log unit-wopi-saveas-with-encoded-file-name.log unit-storage.log unit-wopi-async-upload-modifyclose.log unit-wopi-saveas.log unit_wopi_renamefile.log unit-wopi-loadencoded.log unit-prefork.log unit-bad-doc-load.log unit-hosting.log unit-join-disconnect.log unit-initial-load-fail.log unit-timeout.log unit-timeout_socket.log unit-timeout_wsping.log unit-timeout_conn.log unit-timeout_none.log unit-base.log unithttplib.log
test -z "unit-perf.trs unit-proxy.trs unit-synthetic-lok.trs unit-wopi-async-slow.trs unit-tiletest.trs unit-wopi-fail-upload.trs unit-each-view.trs unit-wopi-stuck-save.trs unit-load.trs unit-integration.trs unit-httpws.trs unit-quarantine.trs unit-load-torture.trs unit-save-torture.trs unit-copy-paste.trs unit-copy-paste-writer.trs unit-crash.trs unit-wopi-fileurl.trs unit-wopi-save-on-exit.trs unit-wopi-documentconflict.trs unit-close.trs unit-wopi-languages.trs unit-insert-delete.trs unit-password-protected.trs unit-uno-command.trs unit-wopi-httpredirect.trs unit-wopi-watermark.trs unit-wopi-lock.trs unit-calc.trs unit-http.trs unit-wopi-temp.trs unit-session.trs unit-render-shape.trs unit-wopi-ownertermination.trs unit-wopi-httpheaders.trs unit-wopi.trs unit-wopi-crash-modified.trs unit-oauth.trs unit-wopi-versionrestore.trs unit-convert.trs unit-rendering-options.trs unit-paste.trs unit-large-paste.trs unit-typing.trs unit-cursor.trs unit-render-search-result.trs unit-tiff-load.trs unit-wopi-saveas-with-encoded-file-name.trs unit-storage.trs unit-wopi-async-upload-modifyclose.trs unit-wopi-saveas.trs unit_wopi_renamefile.trs unit-wopi-loadencoded.trs unit-prefork.trs unit-bad-doc-load.trs unit-hosting.trs unit-join-disconnect.trs unit-initial-load-fail.trs unit-timeout.trs unit-timeout_socket.trs unit-timeout_wsping.trs unit-timeout_conn.trs unit-timeout_none.trs unit-base.trs unithttplib.trs" || rm -f unit-perf.trs unit-proxy.trs unit-synthetic-lok.trs unit-wopi-async-slow.trs unit-tiletest.trs unit-wopi-fail-upload.trs unit-each-view.trs unit-wopi-stuck-save.trs unit-load.trs unit-integration.trs unit-httpws.trs unit-quarantine.trs unit-load-torture.trs unit-save-torture.trs unit-copy-paste.trs unit-copy-paste-writer.trs unit-crash.trs unit-wopi-fileurl.trs unit-wopi-save-on-exit.trs unit-wopi-documentconflict.trs unit-close.trs unit-wopi-languages.trs unit-insert-delete.trs unit-password-protected.trs unit-uno-command.trs unit-wopi-httpredirect.trs unit-wopi-watermark.trs unit-wopi-lock.trs unit-calc.trs unit-http.trs unit-wopi-temp.trs unit-session.trs unit-render-shape.trs unit-wopi-ownertermination.trs unit-wopi-httpheaders.trs unit-wopi.trs unit-wopi-crash-modified.trs unit-oauth.trs unit-wopi-versionrestore.trs unit-convert.trs unit-rendering-options.trs unit-paste.trs unit-large-paste.trs unit-typing.trs unit-cursor.trs unit-render-search-result.trs unit-tiff-load.trs unit-wopi-saveas-with-encoded-file-name.trs unit-storage.trs unit-wopi-async-upload-modifyclose.trs unit-wopi-saveas.trs unit_wopi_renamefile.trs unit-wopi-loadencoded.trs unit-prefork.trs unit-bad-doc-load.trs unit-hosting.trs unit-join-disconnect.trs unit-initial-load-fail.trs unit-timeout.trs unit-timeout_socket.trs unit-timeout_wsping.trs unit-timeout_conn.trs unit-timeout_none.trs unit-base.trs unithttplib.trs
test -z "test-suite.log" || rm -f test-suite.log
rm -f *.lo
make[1]: Leaving directory '/workspace/online/test'
Making clean in cypress_test
make[1]: Entering directory '/workspace/online/cypress_test'
rm -rf .libs _libs
rm -rf node_modules
rm -rf workdir
rm -rf cypress
rm -rf integration_tests/snapshots/actual
rm -rf package-lock.json
rm -rf .nyc_output
rm -rf coverage
rm -f *.lo
make[1]: Leaving directory '/workspace/online/cypress_test'
gitpod /workspace/online (master) $ make run -j16
mkdir -p /workspace/online/jails
make  all-recursive
make[1]: Entering directory '/workspace/online'
Making all in .
make[2]: Entering directory '/workspace/online'
  CXX      common/FileUtil.o
  CXX      common/Session.o
  CXX      common/SigUtil.o
  CXX      common/Unit.o
  CXX      net/DelaySocket.o
  CXX      net/HttpRequest.o
  CXX      net/HttpHelper.o
  CXX      net/NetUtil.o
  CXX      net/Socket.o
  CXX      wsd/Exceptions.o
  CXX      net/Ssl.o
  CXX      kit/forkit-main.o
  CC       kit/libsimd_a-DeltaSimd.o
  CXX      tools/coolstress-Stress.o
  CXX      common/coolstress-DummyTraceEventEmitter.o
  CXX      tools/mount.o
  CXX      common/coolstress-FileUtil.o
  CXX      common/coolstress-JailUtil.o
  CXX      common/coolstress-Log.o
In file included from ./net/DelaySocket.hpp:14,
                 from net/DelaySocket.cpp:14:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from ./net/DelaySocket.hpp:14,
                 from net/DelaySocket.cpp:14:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/Unit.hpp:21,
                 from common/Unit.cpp:10:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from common/Unit.hpp:21,
                 from common/Unit.cpp:10:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from ./net/DelaySocket.hpp:14,
                 from net/DelaySocket.cpp:14:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from net/HttpRequest.hpp:32,
                 from net/HttpRequest.cpp:14:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from net/HttpRequest.hpp:32,
                 from net/HttpRequest.cpp:14:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/SigUtil.cpp:46:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from common/SigUtil.cpp:46:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from ./net/HttpRequest.hpp:32,
                 from net/HttpHelper.hpp:15,
                 from net/HttpHelper.cpp:14:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from ./net/HttpRequest.hpp:32,
                 from net/HttpHelper.hpp:15,
                 from net/HttpHelper.cpp:14:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from net/Socket.cpp:14:
net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from net/Socket.cpp:14:
net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/Unit.hpp:21,
                 from common/Unit.cpp:10:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from net/NetUtil.cpp:18:
net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from net/NetUtil.cpp:18:
net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from net/HttpRequest.hpp:32,
                 from net/HttpRequest.cpp:14:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from ./net/HttpRequest.hpp:32,
                 from net/HttpHelper.hpp:15,
                 from net/HttpHelper.cpp:14:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from common/SigUtil.cpp:46:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from net/NetUtil.cpp:18:
net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from net/Socket.cpp:14:
net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from ./net/WebSocketHandler.hpp:15,
                 from common/Session.hpp:29,
                 from common/Session.cpp:14:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from ./net/WebSocketHandler.hpp:15,
                 from common/Session.hpp:29,
                 from common/Session.cpp:14:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp: In member function ‘int Socket::getSendBufferSize() const’:
./net/Socket.hpp:322:67: error: ‘INT_MAX’ was not declared in this scope
  322 |     int getSendBufferSize() const { return (Util::isMobileApp() ? INT_MAX : _sendBufferSize); }
      |                                                                   ^~~~~~~
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp:41:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   40 | #include "FakeSocket.hpp"
  +++ |+#include <climits>
   41 | 
  CXX      common/coolstress-Protocol.o
In file included from ./net/WebSocketHandler.hpp:15,
                 from common/Session.hpp:29,
                 from common/Session.cpp:14:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
In file included from common/Unit.hpp:21,
                 from common/FileUtil.cpp:48:
./net/Socket.hpp: In member function ‘int StreamSocket::getSendBufferCapacity() const’:
./net/Socket.hpp:1429:20: error: ‘INT_MAX’ was not declared in this scope
 1429 |             return INT_MAX; // We want to always send a single record in one go
      |                    ^~~~~~~
./net/Socket.hpp:1429:20: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
make[2]: *** [Makefile:3466: net/DelaySocket.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:3466: common/SigUtil.o] Error 1
make[2]: *** [Makefile:5226: common/coolstress-FileUtil.o] Error 1
make[2]: *** [Makefile:3466: common/FileUtil.o] Error 1
make[2]: *** [Makefile:3466: net/NetUtil.o] Error 1
make[2]: *** [Makefile:3466: net/HttpRequest.o] Error 1
make[2]: *** [Makefile:3466: net/HttpHelper.o] Error 1
make[2]: *** [Makefile:3466: common/Unit.o] Error 1
make[2]: *** [Makefile:3466: common/Session.o] Error 1
make[2]: *** [Makefile:3466: net/Socket.o] Error 1
make[2]: Leaving directory '/workspace/online'
make[1]: *** [Makefile:7489: all-recursive] Error 1
make[1]: Leaving directory '/workspace/online'
make: *** [Makefile:2075: all] Error 2
Darshan-upadhyay1110 commented 1 month ago

hii @Mark-a-obrien can you please rebase your master and then try ?

Mark-a-obrien commented 1 month ago

Hi @Darshan-upadhyay1110,

I'm still not getting "the URL ending with: hello-world.odt" in the left terminal pane.

 HISTFILE=/workspace/.gitpod/cmd-1 history -r; {
gp sync-await configuring
} && {
make -j$(nproc) run
}
info[gp-vncsession]: * system message bus already started; not starting.
info[gp-vncsession]: Starting tigerVNC server on port 5900
gitpod /workspace/online (master) $  HISTFILE=/workspace/.gitpod/cmd-1 history -r; {
> gp sync-await configuring
> } && {
> make -j$(nproc) run
> }
configuring done
mkdir -p /workspace/online/jails
make  all-recursive
make[1]: Entering directory '/workspace/online'
Making all in .
make[2]: Entering directory '/workspace/online'
  CXX      kit/ChildSession.o
  CXX      kit/ForKit.o
  CXX      kit/Kit.o
  CXX      kit/KitWebSocket.o
  CXX      common/FileUtil.o
  CXX      common/JailUtil.o
  CXX      common/Log.o
  CXX      common/Protocol.o
  CXX      common/StringVector.o
  CXX      common/Session.o
  CXX      common/Seccomp.o
  CXX      common/MobileApp.o
  CXX      common/TraceEvent.o
  CXX      common/SigUtil.o
  CXX      common/SpookyV2.o
  CXX      common/Unit.o
  CXX      common/Uri.o
npm WARN old lockfile 
npm WARN old lockfile The npm-shrinkwrap.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile 
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile 
  CXX      common/Util.odealTree:inflate:node_modules/@babel/helper-
  CXX      common/Util-desktop.o:inflate:node_modules/@babel/helper-
  CXX      common/ConfigUtil.oee:inflate:node_modules/@mapbox/node-p
  CXX      common/Authorization.oinflate:node_modules/@types/mocha: 
  CXX      common/CommandControl.onflate:node_modules/agent-base: si
  CXX      common/Simd.o
  CXX      common/CoolMount.oree:inflate:node_modules/arrify: sill i
  CXX      kit/KitQueue.oealTree:inflate:node_modules/autoprefixer/n
  CXX      net/DelaySocket.oTree:inflate:node_modules/browser-proces
  CXX      net/HttpRequest.oTree:inflate:node_modules/callsites: sil
  CXX      net/HttpHelper.olTree:inflate:node_modules/combine-source
  CXX      net/NetUtil.odealTree:inflate:node_modules/detect-file: s
  CXX      net/Socket.oidealTree:inflate:node_modules/domutils: sill
  CXX      wsd/Exceptions.olTree:inflate:node_modules/elliptic: sill
  CXX      net/Ssl.o ⠦ idealTree:inflate:node_modules/espree: sill i
  CXX      kit/forkit-main.oTree:inflate:node_modules/find-up: sill 
  CC       kit/libsimd_a-DeltaSimd.olate:node_modules/merge: sill in
  CXX      tools/mount.odealTree:inflate:node_modules/minimalistic-c
  CXX      tools/coolstress-Stress.olate:node_modules/nan: sill infl
  CXX      common/coolstress-DummyTraceEventEmitter.o/npm-logical-tr
  CXX      common/coolstress-FileUtil.o
  CXX      common/coolstress-JailUtil.oe:node_modules/onetime: sill 
  CXX      common/coolstress-Log.onflate:node_modules/quick-lru: sil
  CXX      common/coolstress-Protocol.oe:node_modules/side-channel: 
  CXX      common/coolstress-StringVector.ode_modules/sugarss: sill 
  CXX      common/coolstress-Session.ote:node_modules/ws: http fetch
  CXX      common/coolstress-Seccomp.oer: sill idealTree buildDeps
  CXX      common/coolstress-MobileApp.o: sill idealTree buildDeps
  CXX      common/coolstress-TraceEvent.o sill idealTree buildDeps
  CXX      common/coolstress-SigUtil.oer: timing idealTree:#root Com
  CXX      common/coolstress-SpookyV2.or: timing idealTree:#root Com
  CXX      common/coolstress-Unit.oowser: timing idealTree:#root Com
  CXX      common/coolstress-Uri.orowser: timing idealTree:#root Com
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'shrinkpack@1.0.0-alpha',
npm WARN EBADENGINE   required: { node: '>=4.0', npm: '<=5.8.0' },
npm WARN EBADENGINE   current: { node: 'v16.18.1', npm: '8.19.2' }
npm WARN EBADENGINE }
  CXX      common/coolstress-Util.oiming idealTree Completed in 2636
  CXX      common/coolstress-Util-desktop.oealTree Completed in 2636
  CXX      common/coolstress-ConfigUtil.o
  CXX      common/coolstress-Authorization.oreify mark deleted [ '/w
  CXX      common/coolstress-CommandControl.oeify mark deleted [ '/w
  CXX      common/coolstress-Simd.o
  CXX      common/coolstress-CoolMount.o
  CXX      kit/coolstress-KitQueue.o
  CXX      net/coolstress-DelaySocket.o
  CXX      net/coolstress-HttpRequest.o
  CXX      net/coolstress-HttpHelper.o
  CXX      net/coolstress-NetUtil.ots: sill reify mark deleted [ '/w
  CXX      net/coolstress-Socket.o
  CXX      wsd/coolstress-Exceptions.o
  CXX      net/coolstress-Ssl.oevents: sill reify mark deleted [ '/w
  CXX      tools/Tool.oreify:fsevents: sill reify mark deleted [ '/w
  CXX      tools/Config.oify:fsevents: sill reify mark deleted [ '/w
npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
  CXX      tools/ConfigMigrationAssistant.ohttp fetch GET 200 https:
npm WARN deprecated w3c-hr-time@1.0.2: Use your platform's native performance.now() and performance.timeOrigin.
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
  CXX      common/DummyTraceEventEmitter.oerve-symlinks-flag: http f
npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
  CXX      common/Crypto.o
  CXX      wsd/Admin.o
  CXX      wsd/AdminModel.oy:simple-get: http fetch GET 200 https://
  CXX      wsd/Auth.o⠦ reify:shasum-object: http fetch GET 200 https
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
  CXX      wsd/COOLWSD.o
npm WARN deprecated socks@1.1.10: If using 2.x branch, please upgrade to at least 2.1.6 to avoid a serious bug with socket data flow and an import issue introduced in 2.1.0
  CXX      wsd/ClientRequestDispatcher.oectory: http fetch GET 200 h
npm WARN deprecated osenv@0.1.5: This package is no longer supported.
npm WARN deprecated npmlog@5.0.1: This package is no longer supported.
  CXX      wsd/ClientSession.opm-packlist: http fetch GET 200 https:
npm WARN deprecated move-concurrently@1.0.1: This package is no longer supported.
npm WARN deprecated lock-verify@2.2.2: This package is no longer supported.
npm WARN deprecated node-fetch-npm@2.0.4: This module is not used anymore, npm uses minipass-fetch for its fetch implementation now
  CXX      wsd/DocumentBroker.o
  CXX      wsd/FileServer.oy:get-stream: http fetch GET 200 https://
  CXX      wsd/FileServerUtil.o
npm WARN deprecated find-npm-prefix@1.0.2: This package is no longer supported.
npm WARN deprecated figgy-pudding@3.5.2: This module is no longer supported.
npm WARN deprecated fs-write-stream-atomic@1.0.10: This package is no longer supported.
npm WARN deprecated domexception@2.0.1: Use your platform's native DOMException instead
npm WARN deprecated gauge@3.0.2: This package is no longer supported.
  CXX      wsd/HostUtil.o
npm WARN deprecated copy-concurrently@1.0.5: This package is no longer supported.
  CXX      wsd/ProofKey.oify:constants-browserify: http fetch GET 20
npm WARN deprecated are-we-there-yet@2.0.0: This package is no longer supported.
npm WARN deprecated abab@2.0.6: Use your platform's native atob() and btoa() methods instead
npm WARN deprecated @stylelint/postcss-markdown@0.36.2: Use the original unforked package instead: postcss-markdown
In file included from wsd/ClientSession.hpp:16,
                 from wsd/ClientSession.cpp:14:
wsd/SenderQueue.hpp: In instantiation of ‘bool SenderQueue<Item>::deduplicate(const Item&) [with Item = std::shared_ptr<Message>]’:
wsd/SenderQueue.hpp:36:47:   required from ‘size_t SenderQueue<Item>::enqueue(const Item&) [with Item = std::shared_ptr<Message>; size_t = long unsigned int]’
wsd/ClientSession.cpp:2619:58:   required from here
wsd/SenderQueue.hpp:104:33: error: no match for ‘operator!=’ (operand types are ‘const TileDesc’ and ‘TileDesc’)
  104 |                     if (newTile != TileDesc::parse(cur->firstLine()))
      |                         ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
npm WARN deprecated are-we-there-yet@1.1.7: This package is no longer supported.
npm WARN deprecated npmlog@4.1.2: This package is no longer supported.
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated @stylelint/postcss-css-in-js@0.37.3: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
In file included from /usr/include/c++/9/string:52,
                 from /usr/include/c++/9/stdexcept:39,
                 from /usr/include/c++/9/array:39,
                 from /usr/include/c++/9/tuple:39,
                 from /usr/include/c++/9/bits/unique_ptr.h:37,
                 from /usr/include/c++/9/memory:80,
                 from ./common/Session.hpp:16,
                 from wsd/ClientSession.hpp:14,
                 from wsd/ClientSession.cpp:14:
/usr/include/c++/9/bits/stl_algo.h:3960:5: error: ‘_IIter std::find_if(_IIter, _IIter, _Predicate) [with _IIter = std::_Deque_iterator<std::shared_ptr<Message>, std::shared_ptr<Message>&, std::shared_ptr<Message>*>; _Predicate = SenderQueue<Item>::deduplicate(const Item&) [with Item = std::shared_ptr<Message>]::<lambda(const queue_item_t&)>]’, declared using local type ‘SenderQueue<Item>::deduplicate(const Item&) [with Item = std::shared_ptr<Message>]::<lambda(const queue_item_t&)>’, is used but never defined [-fpermissive]
 3960 |     find_if(_InputIterator __first, _InputIterator __last,
      |     ^~~~~~~
/usr/include/c++/9/bits/stl_algo.h:3960:5: error: ‘_IIter std::find_if(_IIter, _IIter, _Predicate) [with _IIter = std::_Deque_iterator<std::shared_ptr<Message>, std::shared_ptr<Message>&, std::shared_ptr<Message>*>; _Predicate = SenderQueue<Item>::deduplicate(const Item&) [with Item = std::shared_ptr<Message>]::<lambda(const queue_item_t&)>]’, declared using local type ‘SenderQueue<Item>::deduplicate(const Item&) [with Item = std::shared_ptr<Message>]::<lambda(const queue_item_t&)>’, is used but never defined [-fpermissive]
/usr/include/c++/9/bits/stl_algo.h:3960:5: error: ‘_IIter std::find_if(_IIter, _IIter, _Predicate) [with _IIter = std::_Deque_iterator<std::shared_ptr<Message>, std::shared_ptr<Message>&, std::shared_ptr<Message>*>; _Predicate = SenderQueue<Item>::deduplicate(const Item&) [with Item = std::shared_ptr<Message>]::<lambda(const queue_item_t&)>]’, declared using local type ‘SenderQueue<Item>::deduplicate(const Item&) [with Item = std::shared_ptr<Message>]::<lambda(const queue_item_t&)>’, is used but never defined [-fpermissive]
/usr/include/c++/9/bits/stl_algo.h:3960:5: error: ‘_IIter std::find_if(_IIter, _IIter, _Predicate) [with _IIter = std::_Deque_iterator<std::shared_ptr<Message>, std::shared_ptr<Message>&, std::shared_ptr<Message>*>; _Predicate = SenderQueue<Item>::deduplicate(const Item&) [with Item = std::shared_ptr<Message>]::<lambda(const queue_item_t&)>]’, declared using local type ‘SenderQueue<Item>::deduplicate(const Item&) [with Item = std::shared_ptr<Message>]::<lambda(const queue_item_t&)>’, is used but never defined [-fpermissive]
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated glob@7.1.6: Glob versions prior to v9 are no longer supported
npm WARN deprecated debug@4.2.0: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated rimraf@2.6.3: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
make[2]: *** [Makefile:3466: wsd/ClientSession.o] Error 100 https://
make[2]: *** Waiting for unfinished jobs....
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated gauge@2.7.4: This package is no longer supported.
npm WARN deprecated eslint@7.0.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 907 packages, and audited 908 packages in 1m

116 packages are looking for funding
  run `npm fund` for details

37 vulnerabilities (2 low, 11 moderate, 23 high, 1 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
npm notice 
npm notice New major version of npm available! 8.19.2 -> 10.9.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.9.0
npm notice Run npm install -g npm@10.9.0 to update!
npm notice 
make[2]: Leaving directory '/workspace/online'
make[1]: *** [Makefile:7489: all-recursive] Error 1
make[1]: Leaving directory '/workspace/online'
make: *** [Makefile:2075: all] Error 2
gitpod /workspace/online (master) $ 
Darshan-upadhyay1110 commented 1 month ago

@Mark-a-obrien yes I already tested that file a bug report for that : https://github.com/CollaboraOnline/online/issues/10345

Thanks I will ping you once it got fixed

Sorry for the taking much time on this 🙇🏼

Darshan-upadhyay1110 commented 2 weeks ago

hello @Mark-a-obrien Gitpod issue is fixed https://github.com/CollaboraOnline/online/pull/10459 🎉