search

CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.88k stars 710 forks source link

Calc: Comment popup: Tab key doesn't cycle focus #9479

Open pedropintosilva opened 4 months ago

pedropintosilva commented 4 months ago

Describe the Bug

Pressing the "Tab" key doesn't change the focus from the text area to the next interactive element in the popup (button). Instead, it moves the cell cursor to the next cell as if the user was not currently inserting a comment.

Steps to Reproduce

  1. Open a spreadsheet
  2. Press the Insert a comment button or trigger the shortcut ctrl + alt + M
  3. Type something
  4. Press "Tab" key.

Expected Behavior

Focus changing from the text area to the buttons of the comment popup.

Actual Behavior

The current situation: The focus leaves the comment popup and the cell cursor moves to the next cell, the comment popup is now open in a undetermined stated (user might now know if it's saved)

Screenshots

https://github.com/CollaboraOnline/online/assets/65948705/8e941ed7-817a-44f2-88a0-5bcc91c480ce

Desktop

on staging perf

COOLWSD version: 24.04.5.1 (git hash: 719d8d7b (E)) LOKit version: Collabora Office 24.04.5.1 (git hash: 9880a99) Served by: openSUSE Leap 15.5 Server ID: 6e2cb173

Darshan-upadhyay1110 commented 1 month ago

In the latest update, focus is now shifting towards buttons like "Cancel" and "Ok," so it's partially fixed. However, the focus should be cyclic, which is not happening currently.